dropshot-api-manager 0.7.1

[david-crespo]

Intended to supersede #1128, which undoes the Dropshot bump.

Dropshot 0.17 includes a change oxidecomputer/dropshot#1554 that changes the OpenAPI schema for websocket endpoints. Normally to account for a schema change you just have to bump the API version, but dropshot-api-manager is thrown off because when it regenerates the schema for the blessed (old) version, it doesn't match what's on disk because the one on disk doesn't have the websocket change in it. This required oxidecomputer/dropshot-api-manager#87, which tells dropshot-api-manager specifically to ignore that websocket schema change. You still have to add an API version.

Also had to bump progenitor for oxidecomputer/progenitor#1320.

[david-crespo]

This is copied from #1128

[david-crespo]

It seems the one remaining check failure is expected.

propolis/.github/buildomat/jobs/phd-run-migrate-from-base.sh

Lines 16 to 25 in 40dbfad

	# This job runs the PHD migrate-from-base tests, which test upgrading from the
	# current mainline propolis-server to the propolis-server version under test.
	#
	# PHD always uses the propolis-client from the commit under test, so these tests
	# will fail if there is a breaking change to the Propolis API. They'll also fail
	# if there's a breaking change to the migration protocol. These changes may be
	# expected, in which case this run will fail. However, the "regular" phd-run
	# job should always be green before merging new PRs.
	#
	# This job will be removed once API breaking changes are no longer allowed.

[jmpesp]

It seems the one remaining check failure is expected.

propolis/.github/buildomat/jobs/phd-run-migrate-from-base.sh

Lines 16 to 25 in 40dbfad

	# This job runs the PHD migrate-from-base tests, which test upgrading from the
	# current mainline propolis-server to the propolis-server version under test.
	#
	# PHD always uses the propolis-client from the commit under test, so these tests
	# will fail if there is a breaking change to the Propolis API. They'll also fail
	# if there's a breaking change to the migration protocol. These changes may be
	# expected, in which case this run will fail. However, the "regular" phd-run
	# job should always be green before merging new PRs.
	#
	# This job will be removed once API breaking changes are no longer allowed.

In lieu of addressing this here, maybe we should open an issue and limit this PR to only adding cargo text -- test_apis_up_to_date?

[jmpesp]

Nevermind, the Rust workflow isn't activating for PRs, disregard - though that may be its own problem to address

[jmpesp]

However I think the original change from the other PR to add fetch depth isn't right. From omicron:

    - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
      with:
        ref: ${{ github.event.pull_request.head.sha }} # see omicron#4461
        fetch-depth: 0 # git-stub-vcs needs full history

[david-crespo]

ah, ew oxidecomputer/omicron#4461. will update

[jmpesp]

I think you need the with: here

[david-crespo]

this is what I get for doing it by hand

[jmpesp]

also this needs to be under the build-and-test job :)

[iximeow]

Instead, it checks out a merge commit of the PR tip with the target branch as of the time the PR was created.

til and what in the world

[iximeow]

nice, thanks.

mote for later re. steps.with.ref being github.event.pull_request.head.sha: consensus is that we'd expect the tests to all pass regardless of the specific ref used for tests here. for the same reason as in Omicron#4461 it's better for GH Actions and buildomat to test changes the same way, so it doesn't hurt to include here too.