rdl: fix improperly configured field sw access - #508
Merged
Conversation
Aaron-Hartwig
commented
Jul 17, 2026
| desc = ""; | ||
|
|
||
| field { | ||
| default sw = woclr; |
Collaborator
Author
There was a problem hiding this comment.
This is actually an invalid statement which was swallowed by the compiler since default is meaningless within field. woclr is a bool type that can be set on its own, so I adjusted that.
1 task
|
Great catch! Do we need to do anything to update the JSON files checked into |
Collaborator
Yep we'll need to push new releases to hubris with the json files I'll work on making that happen this week. |
nathanaelhuffman
approved these changes
Jul 22, 2026
nathanaelhuffman
left a comment
nathanaelhuffman
left a comment
Collaborator
There was a problem hiding this comment.
ty for digging into this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In SystemRDL, the
defaultkeyword only applies to children within the scope it is declared. This means when it is used within afield(which can't have children), nothing happens. Additionally, it does not set the property locally (that is, on thefield), so all the places wheredefault $property = $valueexist within a field don't actually do anything. This PR fixes all the occurrences where we did this within our RDL definitions.Fixes #507