delete InternalError::Unknown - #227
Merged
sunshowers merged 1 commit intoSep 4, 2026
Conversation
Previously, `last_err` returned `Unknown` if no tokens had been read. Contrary to the comments there, it is actually possible to hit this case in situations like `Named()` or an empty declarative macro substitution. Change things so that every `TokenDe` now carries the enclosing group. This lets us remove the `Unknown` variant and fix a couple of panics.
ahl
approved these changes
Sep 4, 2026
sunshowers
deleted the
jj-stack/delete-internalerror-unknown-okrnyrzq
branch
September 4, 2026 20:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
last_errreturnedUnknownif no tokens had been read. Contrary to the comments there, it is actually possible to hit this case in situations likeNamed()or an empty declarative macro substitution.Change things so that every
TokenDenow carries the enclosing group. This lets us remove theUnknownvariant and fix a couple of panics.