Move the library and gpui on again, and take a yanked crate back off - #69
Conversation
`cargo update` on top of #64. The lock file alone: nothing in the manifests had to be asked for a new version and nothing upstream removed anything this tree names. - **whatsapp-rust** and its ten satellites: `2421037e` -> `5370f021`. A snapshot fold now says how many records reached it without an index (oxidezap/whatsapp-rust#1373), which is the diagnostic half of the MAC mismatch work #64 brought in. - **zed** (`gpui`, `gpui_platform` and their satellites): `9785475c` -> `ce48461e`, one commit: `util` no longer panics parsing a malformed shell variable (zed#63446). - **gpui-component** did not move; it is still at the tip #63 put it on. - **lyon_algorithms** and **lyon_tessellation** 1.0.20 -> 1.0.21, transitive through gpui's tessellator. ## The one entry that went backwards `value-bag` 1.14.0 -> 1.13.2, which is a *downgrade* and is correct: 1.14.0 has been yanked from crates.io since #63 locked it. Read out of the registry index rather than guessed -- the cached entry for 1.14.0 carries `yanked: true` and 1.13.2 does not -- because a lock file moving a version backwards is the shape of a mistake, and saying which it is here is cheaper than working it out again at the next bump. It reaches this graph through `log`'s structured values. ## Verified `cargo fmt --all -- --check`, `cargo clippy --workspace --all-targets -- -D warnings` and `cargo test --workspace` all clean against the new revisions, plus `cargo +nightly check` on `wasm32-unknown-unknown` for `oxidezap-gui` and `oxidezap-session`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017ZQ28Vqpc3pCasXu3Rzzja
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 participants
cargo updateon top of #64. The lock file alone: nothing in the manifests hadto be asked for a new version, and nothing upstream removed anything this tree
names — so unlike #64 there is no code change to follow it.
The git sources
2421037e→5370f021. A snapshotfold now says how many records reached it without an index
(Say how many snapshot records reached the fold without an index whatsapp-rust#1373), which is the diagnostic half of the MAC
mismatch work Follow the library's JID change, and move it and gpui on again #64 brought in.
gpui,gpui_platformand their satellites):9785475c→ce48461e, one commit:utilno longer panics parsing a malformed shellvariable (util: Prevent panic when parsing a malformed shell variable zed-industries/zed#63446).
The registry deps
lyon_algorithmsandlyon_tessellation1.0.20 → 1.0.21, transitive throughgpui's tessellator.
The one entry that went backwards
value-bag1.14.0 → 1.13.2, which is a downgrade and is correct: 1.14.0has been yanked from crates.io since #63 locked it. Read out of the registry
index rather than guessed — the cached entry for 1.14.0 carries
yanked: trueand 1.13.2 does not — because a lock file moving a version backwards is the
shape of a mistake, and saying which it is here is cheaper than working it out
again at the next bump. It reaches this graph through
log's structuredvalues.
What
cargo updatestill lists, and why it staysUnchanged: the deliberate dual-major
getrandom(0.4 forwacore, 0.2 for theolder transitive dependency, each naming its own wasm backend);
cocoaandgeneric-array, transitive and not ours to pin; and the fourrtc-*crates,which come from the library's VoIP stack.
Verified
cargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warningsandcargo test --workspace(every suite green) against the newrevisions, plus
cargo +nightly checkonwasm32-unknown-unknownfor bothoxidezap-guiandoxidezap-session.🤖 Generated with Claude Code
https://claude.ai/code/session_017ZQ28Vqpc3pCasXu3Rzzja
Generated by Claude Code
Summary by cubic
Runs
cargo updateon top of the previous lock update to movewhatsapp-rustandgpuiforward, and takesvalue-bagback to 1.13.2 because 1.14.0 is yanked from crates.io. The lock file only — nothing in the manifests changed.whatsapp-rustand its ten satellites move to a revision where the snapshot fold reports how many records reached it without an index, the diagnostic half of the MAC mismatch work.gpuiand its satellites move one commit forward:utilno longer panics parsing a malformed shell variable.lyon_algorithmsandlyon_tessellationmove 1.0.20 → 1.0.21, transitive through gpui's tessellator.value-bag1.14.0 → 1.13.2 move is a deliberate downgrade; 1.14.0 is markedyanked: truein the registry index and reaches this graph throughlog's structured values.Verified clean with
cargo fmt,cargo clippy -D warnings,cargo test --workspace, andcargo +nightly checkonwasm32-unknown-unknownforoxidezap-guiandoxidezap-session.Written for commit aea9884. Summary will update on new commits.