Skip to content

Fix incorrect default value for pre-commands cwd in documentation - #7602

Merged
nvuillam merged 2 commits into
mainfrom
copilot/fix-default-value-precommands-cwd
Apr 18, 2026
Merged

Fix incorrect default value for pre-commands cwd in documentation#7602
nvuillam merged 2 commits into
mainfrom
copilot/fix-default-value-precommands-cwd

Conversation

Copilot AI commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

The documentation table for Pre-commands listed workspace as the default value for cwd, contradicting both the actual runtime behavior (command_info.get("cwd", "root") in pre_post_factory.py) and the JSON schema ("default": "root"). Users omitting cwd would get Docker container root execution instead of the expected workspace root.

Changes

  • README.md and docs/config-precommands.md: Corrected the cwd default value in the Pre-commands property table from workspaceroot

The JSON schema was already correct and required no changes.

Users relying on the documented workspace default must explicitly set cwd: workspace in their pre-commands config.

Copilot AI changed the title [WIP] Fix incorrectly default value for Pre-commands' cwd in documentation Fix incorrect default value for pre-commands cwd in documentation Apr 18, 2026
Copilot AI requested a review from nvuillam April 18, 2026 17:45
@nvuillam
nvuillam marked this pull request as ready for review April 18, 2026 17:51
@nvuillam
nvuillam merged commit 6a40843 into main Apr 18, 2026
@nvuillam
nvuillam deleted the copilot/fix-default-value-precommands-cwd branch April 18, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrectly default value for Pre-commands' cwd in documentation

2 participants