Add biome linter for JavaScript, TypeScript, JSX, TSX, JSON, CSS and GraphQL - #8706
Merged
Conversation
nvuillam
requested review from
Kurt-von-Laven,
bdovaz and
echoix
as code owners
August 9, 2026 17:25
…GraphQL New JAVASCRIPT_BIOME, TYPESCRIPT_BIOME, JSX_BIOME, TSX_BIOME, JSON_BIOME, CSS_BIOME and GRAPHQL_BIOME linters running 'biome check' (lint + format + import sorting in one pass), defined once in a shared linter definition (megalinter/descriptors/shared/biome.megalinter-linter.yml) and extended by the 7 descriptors. - Active only when a biome.json or biome.jsonc file is found in the repository - APPLY_FIXES support through biome --write (safe fixes) - Native SARIF output (--reporter=sarif) - EXCLUDED_DIRECTORIES forwarded in project lint mode by BiomeLinter through a generated configuration extending the workspace one (files.includes negated patterns, user entries preserved, biome.jsonc supported through the new utils.strip_jsonc helper) - Included in cupcake, dotnetweb and javascript flavors - Dedicated test folders with good/bad/fix fixtures and .wireit poison files, all validated against biome 2.5.7
…phql error count) - Add biome.json at each biome test folder root: test_report_sarif uses the folder root as workspace, where activation found no biome configuration - Remove cli_lint_warnings_count/regex: biome only emits warnings for user-configured warn-severity rules, so failure fixtures cannot reliably produce the >1 warnings the test contract requires - Make the graphql bad fixture unformatted so it triggers 2 errors (anonymous operation + format), as test_linter_failure requires >1 error
Biome 2.x treats every biome.json as a root configuration by default: the folder-root config added for the SARIF test turned the good/bad/fix configs into conflicting nested roots, aborting the check before the SARIF report was written. Nested fixture configs now declare root: false.
nvuillam
force-pushed
the
feat/add-biome
branch
from
August 9, 2026 18:49
ee1cb75 to
7dcf2b4
Compare
Contributor
✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds biome (v2.5.7), one fast Rust toolchain linting, formatting and sorting imports, as 7 new linters: JAVASCRIPT_BIOME, TYPESCRIPT_BIOME, JSX_BIOME, TSX_BIOME, JSON_BIOME, CSS_BIOME and GRAPHQL_BIOME.
Behavior
biome check(lint + format checks + assist actions in one pass), with--max-diagnostics=nonebiome.jsonorbiome.jsoncfile is found in the repository — zero noise for non-Biome repos--write(safe fixes)--reporter=sarif)file,list_of_files(default) andprojectBiomeLintergenerates a configuration extending the workspace one with negatedfiles.includespatterns (user entries preserved,biome.jsonccomments handled by the newutils.strip_jsonchelper).css(biome does not support SCSS)Tests
Dedicated test folders (
good/bad/fix+.wireitpoison fixtures guarding the exclusion forwarding), all fixtures validated against biome 2.5.7:Found ([0-9]+) errorbiome check --writeFixes #3572