deps-dev(deps-dev): bump @sveltejs/kit from 2.37.0 to 2.37.1#18
Closed
dependabot[bot] wants to merge 1 commit intomainfrom
Closed
deps-dev(deps-dev): bump @sveltejs/kit from 2.37.0 to 2.37.1#18dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps [@sveltejs/kit](https://github.com/sveltejs/kit/tree/HEAD/packages/kit) from 2.37.0 to 2.37.1. - [Release notes](https://github.com/sveltejs/kit/releases) - [Changelog](https://github.com/sveltejs/kit/blob/main/packages/kit/CHANGELOG.md) - [Commits](https://github.com/sveltejs/kit/commits/@sveltejs/kit@2.37.1/packages/kit) --- updated-dependencies: - dependency-name: "@sveltejs/kit" dependency-version: 2.37.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Author
AssigneesThe following users could not be added as assignees: LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
Superseded by #21. |
dependabot
Bot
deleted the
dependabot/npm_and_yarn/sveltejs/kit-2.37.1
branch
oxyzenQ
added a commit
that referenced
this pull request
May 2, 2026
… backdrop ## Bug Fixes ### Bug #17: Mobile Backdrop Transparency - EncryptionModal & FeedbackModal already fixed in previous commit - Uses var(--cosmic-dark-82/92) with iOS-specific stronger blur ### Bug #18: Duplicate Modal + Wrong Error UI #### Root Cause - BmiForm.svelte showed BOTH FeedbackModal AND called onNotify - +page.svelte then showed NotifyFloat → duplicate modals - NotifyFloat used 'delete' type for errors → Trash icon + 2 buttons #### Fixes Applied 1. **Single Source of Truth** (BmiForm.svelte) - Removed all direct FeedbackModal triggers from handleFileChange - File size guards now use onNotify only - Validation errors now use onNotify only - Import errors from handleImportConfirm still use FeedbackModal (for encrypted file retry flow) 2. **New 'error' Type for NotifyFloat** (NotifyFloat.svelte) - Added 'error' to type union - Uses X icon (not Trash) for error type - Shows only 1 button (OK) for error type - Maintains 2 buttons for 'delete' and 'warn' types 3. **Updated +page.svelte** - Changed import-error from 'delete' to 'error' type - Updated notifyType state type to include 'error' ## Result - Invalid JSON import: Shows 1 modal with X icon, 1 OK button - No duplicate modals - Consistent error UI across all import error scenarios ## Verification - svelte-check: 0 errors, 0 warnings - Build: SUCCESS Closes: Bug #17, Bug #18 - Final stabilization complete ── bmi/dev · c5c097f52b64 · 3 file · +24/-17 · 2026-05-02T17:45:49Z
oxyzenQ
added a commit
that referenced
this pull request
May 2, 2026
## Root Cause File input onchange event tidak fire saat memilih file yang same and input.value belum di-reset setelah error validation. ## Fix - Tambah finally block untuk SELALU reset input.value = '' - Tambah guard on awal: jika !file, tetap reset input - Hapus input.value = '' dari encrypted path (already di-cover finally) ## Verification - svelte-check: 0 errors, 0 warnings - Build: SUCCESS Closes: Bug #18 - file input onchange tidak trigger on file yang same ── bmi/dev · f58658c0cacc · 1 file · +9/-3 · 2026-05-02T17:54:20Z
oxyzenQ
added a commit
that referenced
this pull request
May 2, 2026
## Root Cause File input reset via e.currentTarget.value tidak reliable on Svelte ketika element already di-bind via bind:this. ## Fix - Tambah fungsi resetFileInput() yang pakai bound element (fileInputEl) - Reset dari semua exit paths: error guards, encrypted, success, catch, finally - Lebih reliable karena pakai direct DOM reference ## Files Changed - src/lib/components/BmiForm.svelte ## Verification - svelte-check: 0 errors, 0 warnings - Build: SUCCESS ── bmi/dev · 162c248bbb84 · 1 file · +13/-8 · 2026-05-02T17:59:10Z
oxyzenQ
added a commit
that referenced
this pull request
May 2, 2026
## Fix Gunakan pattern cloneNode + replaceChild untuk paling reliable: 1. fileInputEl.value = '' (standard reset) 2. Clone element dengan semua attributes 3. Replace old element dengan clone 4. Update fileInputEl reference ke element baru Ini memastikan input benar-benar fresh and onchange akan fire saat user pilih file yang same lagi. ## Verification - svelte-check: PASS - Build: SUCCESS ── bmi/dev · f397a04c8cba · 1 file · +10/-4 · 2026-05-02T18:00:41Z
oxyzenQ
added a commit
that referenced
this pull request
May 2, 2026
## Root Cause
Svelte 5 bind:this tidak kompatibel dengan manual DOM manipulation.
Clone+replace pattern did not update binding reference correctly.
## Fix
Use Svelte-native approach dengan {#key} block:
1. Add fileInputKey state ()
2. Wrap input element dengan {#key fileInputKey}
3. On reset, increment key → Svelte remount new element
4. Element baru = fresh state = onchange will fire
## Flow:
- User selects file → onchange fire → process file
- Finally block: fileInputKey++ → input remount
- User selects file lagi (same atau beda) → onchange fire
## Verification
- svelte-check: PASS
- Build: SUCCESS
Ini approach paling reliable because it uses Svelte reactivity system,
not manual DOM manipulation.
── bmi/dev · a8df5192088f · 1 file · +15/-19 · 2026-05-02T18:05:26Z
oxyzenQ
added a commit
that referenced
this pull request
May 2, 2026
…lick
## Fix
Hapus bind:this (timing issue dengan {#key}) and ganti dengan:
1. id='bmi-file-input' on element
2. document.getElementById() on handleImportClick
3. setTimeout 0 untuk ensure DOM ready setelah key change
## Kenapa ini lebih reliable:
- bind:this update asynchronously, bisa stale setelah remount
- getElementById selalu baca DOM real-time
- setTimeout ensure micro-task flush untuk DOM update
## Verification
- svelte-check: PASS
- Build: SUCCESS
── bmi/dev · 7e102e2f7bec · 1 file · +6/-3 · 2026-05-02T18:07:16Z
oxyzenQ
added a commit
that referenced
this pull request
May 2, 2026
…h click
## Root Cause
Semua previous approaches (bind:this, {#key}, getElementById) tidak reliable
karena browser file input behavior yang unik.
## Fix (Nuclear Option)
Create input element programmatically setiap kali Import diklik:
1. handleImportClick() create <input type='file'> fresh
2. Set onchange handler langsung
3. Append ke body, click(), lalu auto-remove via onchange cleanup
Keuntungan:
- Element selalu fresh, belum pernah punya file selected
- onchange will fire untuk file apapun (same atau beda)
- Tidak ada state persistence issue
- Tidak perlu reset/manual cleanup
## Files Changed
- src/lib/components/BmiForm.svelte (complete rewrite of import flow)
## Verification
- svelte-check: PASS
- Build: SUCCESS
── bmi/dev · 9600ae905fd7 · 1 file · +16/-32 · 2026-05-02T18:26:44Z
── bmi/dev · 23d878a118d4 · 1 file · +0/-0 · 2026-05-02T18:29:36Z
oxyzenQ
added a commit
that referenced
this pull request
May 2, 2026
Root cause: missing handler for notifyType === 'error' in onContinue showNotify never became false, so second error didn't trigger effect Fix: add error handler to dismiss notification ── bmi/dev · 3142247ac3ba · 2 file · +3/-5 · 2026-05-02T19:03:12Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @sveltejs/kit from 2.37.0 to 2.37.1.
Release notes
Sourced from
@sveltejs/kit's releases.Changelog
Sourced from
@sveltejs/kit's changelog.Commits
dd19f91Version Packages (#14342)4f883d1chore(deps): update dependency@opentelemetry/sdk-nodeto ^0.204.0 (#14373)b216e47fix: assign correct status code to form submission error on the client (#14345)fb0f5ddfix: resolve_route prevent dropping a trailing slash of id (#14294)86d3889fix: un-proxyform.result(#14346)b2e921cchore: windows-compatible rm -rf (#14344)1c416bcfix: serialize serverloaddata before passing to universal load alternativ...f3a0ddachore: get rid of AbortController when calling queries on server (#14338)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)