ci(deps): bump actions/setup-node from 4 to 5#17
Closed
dependabot[bot] wants to merge 1 commit intomainfrom
Closed
ci(deps): bump actions/setup-node from 4 to 5#17dependabot[bot] wants to merge 1 commit intomainfrom
dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4 to 5. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Author
AssigneesThe following users could not be added as assignees: LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
oxyzenQ
added a commit
that referenced
this pull request
Apr 25, 2026
Path A (Stabilization): - #13: Extract lazy-loading to createLazyLoader/createPairedLazyLoader with onLoad callback bridging to Svelte 5 (-73 lines from +page.svelte) - #15: Replace hardcoded hex colors with CSS variable references in BodyFatEstimate (10 inline styles) and +error.svelte (4 colors) - #17: Add 42 component tests (BmiRadialGauge 8, BodyFatEstimate 13, BmiSnapshot 21) Path B (Luxury Polish): - #14: Enhance skeleton loading with shimmer sweep overlay, breathing pulse animation, and staggered delay system - #16: Add button ripple micro-interaction via delegated click handler in +layout.svelte (CSS was already prepared in animation.css) Build: ✅ | Tests: 162/164 (2 pre-existing NotifyFloat focus-trap flaky) +page.svelte: 1885 → 1812 lines
oxyzenQ
added a commit
that referenced
this pull request
May 2, 2026
… backdrop ## Bug Fixes ### Bug #17: Mobile Backdrop Transparency - EncryptionModal & FeedbackModal already fixed in previous commit - Uses var(--cosmic-dark-82/92) with iOS-specific stronger blur ### Bug #18: Duplicate Modal + Wrong Error UI #### Root Cause - BmiForm.svelte showed BOTH FeedbackModal AND called onNotify - +page.svelte then showed NotifyFloat → duplicate modals - NotifyFloat used 'delete' type for errors → Trash icon + 2 buttons #### Fixes Applied 1. **Single Source of Truth** (BmiForm.svelte) - Removed all direct FeedbackModal triggers from handleFileChange - File size guards now use onNotify only - Validation errors now use onNotify only - Import errors from handleImportConfirm still use FeedbackModal (for encrypted file retry flow) 2. **New 'error' Type for NotifyFloat** (NotifyFloat.svelte) - Added 'error' to type union - Uses X icon (not Trash) for error type - Shows only 1 button (OK) for error type - Maintains 2 buttons for 'delete' and 'warn' types 3. **Updated +page.svelte** - Changed import-error from 'delete' to 'error' type - Updated notifyType state type to include 'error' ## Result - Invalid JSON import: Shows 1 modal with X icon, 1 OK button - No duplicate modals - Consistent error UI across all import error scenarios ## Verification - svelte-check: 0 errors, 0 warnings - Build: SUCCESS Closes: Bug #17, Bug #18 - Final stabilization complete ── bmi/dev · c5c097f52b64 · 3 file · +24/-17 · 2026-05-02T17:45:49Z
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/setup-node from 4 to 5.
Release notes
Sourced from actions/setup-node's releases.
... (truncated)
Commits
a0853c2Bump actions/checkout from 4 to 5 (#1345)b7234ccUpgrade action to use node24 (#1325)d7a1131Enhance caching in setup-node with automatic package manager detection (#1348)5e2628cBumps form-data (#1332)65becefBump undici from 5.28.5 to 5.29.0 (#1295)7e24a65Bump uuid from 9.0.1 to 11.1.0 (#1273)08f58d1Bump@octokit/request-errorand@actions/github(#1227)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)