Skip to content

chore: delete IsLastLID - #469

Merged
cheb0 merged 2 commits into
mainfrom
0-delete-last-lid
Jul 27, 2026
Merged

chore: delete IsLastLID#469
cheb0 merged 2 commits into
mainfrom
0-delete-last-lid

Conversation

@cheb0

@cheb0 cheb0 commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Description

It's easier to just use a new Source interface to iterate over all postings in index analyzer


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

@codecov-commenter

codecov-commenter commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.63%. Comparing base (4ad8f17) to head (5be2437).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/index_analyzer/main.go 0.00% 43 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #469      +/-   ##
==========================================
+ Coverage   70.44%   70.63%   +0.18%     
==========================================
  Files         232      232              
  Lines       18371    18319      -52     
==========================================
- Hits        12942    12939       -3     
+ Misses       4453     4402      -51     
- Partials      976      978       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin
eguguchkin requested a review from dkharms July 23, 2026 17:01
@cheb0
cheb0 enabled auto-merge (squash) July 27, 2026 06:06
@cheb0
cheb0 merged commit a79eceb into main Jul 27, 2026
8 checks passed
@cheb0
cheb0 deleted the 0-delete-last-lid branch July 27, 2026 06:09
@github-actions

Copy link
Copy Markdown
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Indexer-4 4ad8f1 6ace8f
677543019.00 B/op 756189101.00 B/op 1.12 🔴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants