docs(config): note that the node feeds publish a host port either way (#760)#763
Merged
Merged
Conversation
…#760) The e2e caught this on the bench: monerod's 18083 and the Tari node's 18142 are published from this release, loopback unless the LAN switch is on, so anything already holding either port stops the upgrade at 'docker compose up'. Say so in the CHANGELOG upgrade note and beside both config keys. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the pre-release e2e on the bench, not by reading the diff.
monerod's18083and the Tari node's18142are published on the host from this release — on127.0.0.1unlessmonero.zmq_lan_access/tari.grpc_lan_accessis on. Gouda was running two hand-rolledsocatforwards on those exact ports (the arrangement these switches replace), sodocker compose uprefused to start monerod:The behaviour is right and matches the existing
18081/18143publishes — but nothing told an operator their upgrade would stop on a port they'd already taken. This adds a CHANGELOG upgrade note and a sentence beside each config key.No code change: within a single compose file a port entry can't be conditionally omitted, and making the publish conditional would need a rendered override file — new machinery for a case a sentence covers.
Ponytail review: docs only, nothing to cut. markdownlint + docs-voice green.
🤖 Generated with Claude Code