fix(security): mask notification secrets + confirm any shell-gaining OS update (#848, #854) - #865
Merged
Merged
Conversation
…firm any shell-gaining OS update #848: CONTROL_SECRET_PATHS (pithead) and SECRET_PATHS (control_service.py) omitted notifications.ntfy.token/.url and notifications.webhooks[] — the whole webhook URL is a bearer secret. render_masked_config wrote them live into the dashboard-container-readable masked config. Added all three to both lists (webhooks array-masked like workers.list[].token). Also consolidated data_service.py's duplicate masking pass onto a shared mask_secrets() so the third copy can't drift. #854: os_update_needs_confirmation only fired debug->non-debug (losing a shell). A release box taking a debug bundle silently BAKES a root SSH backdoor — now confirmed too (gaining a shell), plus unstamped->unknown. Closes #848 Closes #854 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#848 — notification secrets leaked through the masked-config surface
CONTROL_SECRET_PATHS(pithead) andSECRET_PATHS(control_service.py) omittednotifications.ntfy.token,notifications.ntfy.url, andnotifications.webhooks[]— the whole webhook URL is a bearer secret (docs/configuration.md documents them as secret).render_masked_configwrote the live values into the dashboard-container-readable masked config, contradicting the control-channel invariant. Added all three to BOTH lists (webhooks array-masked likeworkers.list[].token), and consolidateddata_service.py's duplicate masking pass onto a sharedmask_secrets()so the third copy can't drift.#854 — os-update variant gate was one-directional
os_update_needs_confirmation()fired only debug→non-debug (losing a shell). A hardened release box installing a debug bundle silently baked a standing root SSH backdoor with no confirmation. Now confirms on gaining a shell too (debug bundle onto a non-debug box) and on unstamped→unknown, keeping the existing debug→release confirm.Verified
Stack suite 1988/0, dashboard pytest 1733 (control + data service), make lint clean. Both secret lists cross-checked against config.reference.json.
Closes #848
Closes #854
🤖 Generated with Claude Code