XvB follow-ups: target-tier win forecast, stand-down when disabled, wins-log height cap - #877
Merged
Merged
Conversation
…bled Three operator-reported gaps from the first live look at the honest-economics card (develop @ 167891c on the bench): - The expected-wins forecast dashed out on a box holding no tier yet — exactly the operator weighing whether donating is worth enabling. It now speaks to the TARGET tier until one is held (xvb_forecast_tier_key). - A disabled XvB still claimed five Overview tiles, two hero KPIs, a header split line and the whole Donation Stats card — all zeros and Nones. One mode badge says XvB is off; everything else stands down with it. - Grid rows are as tall as their tallest card, and the raffle-wins log made the XvB card tallest by far — every neighbour trailed white space. The log now scrolls inside a capped list. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three operator-reported gaps from the first live look at #874 on the bench:
xvb_forecast_tier_key), and the tooltip/docs say which tier it speaks to..raffle-wins-list, ~6 rows).Testing
Unit tests for the tier-key fallback (held > target > none, drifted-config guard); heroKpis disabled/absent-section cases; component render tests for the stand-down set and the capped-list wrapper. Full suite green, patch coverage 100%, lint + docs voice clean.
🤖 Generated with Claude Code