refactor(wizard): one spool-JSON reader, one atomic writer - #886
Merged
Conversation
Three identical read-parse-swallow-return readers collapse into
_spool_json (absent, unparseable, or non-dict all mean {} — every spool
reader fails open the same way), and _spool_write_config becomes
_spool_clear_error plus _spool_write_text instead of re-implementing the
mkstemp/os.replace atomic write beside it. Behavior pinned by the
existing wizard suite; _reference keeps its underscore-key filter.
The tests/os/run.sh wait-loop half of the finding stays open on #871 —
it needs a bench run to verify, and rides the next change that is
already paying for one.
Refs #871
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #871 (the wizard half; the tests/os/run.sh wait-loop half stays open — it needs a bench run to verify and rides the next change that already pays for one)
Three identical read-parse-swallow-return spool readers collapse into
_spool_json(absent, unparseable, or non-dict all mean{}— every spool reader fails open the same way), and_spool_write_configbecomes_spool_clear_error+_spool_write_textinstead of re-implementing the mkstemp/os.replaceatomic write beside it — removing the chance of the two atomic writes drifting apart.Net −10 lines, no behavior change: the wizard suite (68 tests) pins all the paths, full dashboard suite 1759 passed, patch coverage 100%,
make lintgreen.🤖 Generated with Claude Code