-
-
Notifications
You must be signed in to change notification settings - Fork 119
Made search function non case-sensitive #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Search function (find, find next, replace, replace all) now doesn't differentiate between lower-cases and upper-cases. Previously couldn't find the word "Example" when "example" was typed into the search field.
|
Hi Fitoh! Thanks for the contribution!! Seems perfect. However, I can't test it right now. Did you test it (and on what Java version?). Is that works well? |
|
Hi, tested it in jdk 1.7 (and using NetBeans). Works as it should, I couldn't find any bugs related to my change. There are other bugs however that are still present, mainly one in Replace function. When you try to replace a word that is not present in the text, the program adds to the end of the text the word you wanted to replace the original word with. This particular bug is however present in the current version, so it doesn't have anything to do with the changes I made. |
|
Okay I'll merge it very soon! if(select_start != -1)This (or thing like) should be OK, please let me know. |
Fixed a bug where replace function simply added the replace word to the end of the text when it failed to find the original word that was to be replaced.
This reverts commit a466f1a.
Fixed a bug where replace function simply added the replace word to the end of the text when it failed to find the original word that was to be replaced.
|
Fixed the replace bug (and tested the fix). Sorry about the 2 & 3 commit, didn't notice the automatic changes to project.properties so had to revert to make those go away. The current (4th) commit is OK with both non case sensitivity and the replace bug fixed. |
|
👍 That's brilliant! Thanks Fitoh to contribute 😃 |
Made search function non case-sensitive
|
Glad I could. The compiled jar file is old version though, but I leave that to you if you want to update it at some point. |
Search function (find, find next, replace, replace all) now doesn't
differentiate between lower-cases and upper-cases. Previously couldn't
find the word "Example" when "example" was typed into the search field.