PAB-60: fix pnpm first-run build approvals#133
Merged
Conversation
Co-authored-by: multica-agent <github@multica.ai>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue where pnpm required manual build approvals for certain dependencies during the first install, causing friction in the initial setup process. By explicitly listing these dependencies in the workspace configuration files and enforcing the policy through a new check, the build step now proceeds without user interaction.
Changes
pnpm-workspace.yamlfiles at the repository root and insidebackend/. These files define theonlyBuiltDependencieslists to pre-approve builds for packages such asesbuild,sharp,@sentry/cli, and others.scripts/check-pnpm-build-policy.cjs) that:package.jsondoes not contain deprecated pnpm build settings (pnpm 10 now reads them frompnpm-workspace.yaml).scripts/run-checks.cjsso it runs automatically on every build.Purpose
This prevents pnpm from prompting for build approvals on the first run, making the developer environment setup seamless and reducing potential errors caused by missing post-install scripts. The automated check guards against future regressions.