Skip to content

PAB-60: fix pnpm first-run build approvals#133

Merged
pablopunk merged 1 commit into
mainfrom
agent/coder/b08bf9f3
Jul 17, 2026
Merged

PAB-60: fix pnpm first-run build approvals#133
pablopunk merged 1 commit into
mainfrom
agent/coder/b08bf9f3

Conversation

@pablopunk

@pablopunk pablopunk commented Jul 17, 2026

Copy link
Copy Markdown
Owner

This pull request addresses an issue where pnpm required manual build approvals for certain dependencies during the first install, causing friction in the initial setup process. By explicitly listing these dependencies in the workspace configuration files and enforcing the policy through a new check, the build step now proceeds without user interaction.

Changes

  • Added pnpm-workspace.yaml files at the repository root and inside backend/. These files define the onlyBuiltDependencies lists to pre-approve builds for packages such as esbuild, sharp, @sentry/cli, and others.
  • Introduced a new validation script (scripts/check-pnpm-build-policy.cjs) that:
    • Verifies the correct dependencies are listed in each workspace configuration.
    • Ensures the root package.json does not contain deprecated pnpm build settings (pnpm 10 now reads them from pnpm-workspace.yaml).
    • Fails CI if any required dependency is missing or incorrectly configured.
  • Integrated the new check into the existing scripts/run-checks.cjs so it runs automatically on every build.

Purpose

This prevents pnpm from prompting for build approvals on the first run, making the developer environment setup seamless and reducing potential errors caused by missing post-install scripts. The automated check guards against future regressions.

Co-authored-by: multica-agent <github@multica.ai>
@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nvm Ready Ready Preview, Comment Jul 17, 2026 6:33pm

@kody-ai

kody-ai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Business Logic

Access your configuration settings here.

@pablopunk
pablopunk merged commit d7926a3 into main Jul 17, 2026
10 checks passed
@pablopunk
pablopunk deleted the agent/coder/b08bf9f3 branch July 17, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant