Skip to content

PAB-60: force Electron binary installation#137

Merged
pablopunk merged 1 commit into
mainfrom
agent/coder/pab-60-electron-windows-install
Jul 17, 2026
Merged

PAB-60: force Electron binary installation#137
pablopunk merged 1 commit into
mainfrom
agent/coder/pab-60-electron-windows-install

Conversation

@pablopunk

@pablopunk pablopunk commented Jul 17, 2026

Copy link
Copy Markdown
Owner

This pull request replaces the Electron repair mechanism that previously relied on pnpm rebuild electron with a direct invocation of Electron’s own install.js script. By stripping the ELECTRON_SKIP_BINARY_DOWNLOAD and FORCE_NO_CACHE environment variables (case‑insensitive) and setting force_no_cache=true, the installer now forces a fresh download of the Electron binary from the source every time the repair runs.

The changes remove the pnpmRebuildInvocation and rebuildElectron functions, replacing them with electronInstallerEnvironment (which prepares the required installer environment) and installElectronBinary (which executes the install script). The ensureElectronAvailable function is updated accordingly to use the new installer path, and all related tests, imports, and exports are aligned with the new approach.

This ensures a clean, up‑to‑date Electron binary installation, particularly addressing Windows environments where the previous pnpm‑based rebuild might have used cached or skipped downloads.

Co-authored-by: multica-agent <github@multica.ai>
@vercel

vercel Bot commented Jul 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nvm Ready Ready Preview, Comment Jul 17, 2026 9:30pm

@kody-ai

kody-ai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Kody Review Complete

Great news! 🎉
No issues were found that match your current review configurations.

Keep up the excellent work! 🚀

Kody Guide: Usage and Configuration
Interacting with Kody
  • Request a Review: Ask Kody to review your PR manually by adding a comment with the @kody start-review command at the root of your PR.

  • Validate Business Logic: Ask Kody to validate your code against business rules by adding a comment with the @kody -v business-logic command.

  • Provide Feedback: Help Kody learn and improve by reacting to its comments with a 👍 for helpful suggestions or a 👎 if improvements are needed.

Current Kody Configuration
Review Options

The following review options are enabled or disabled:

Options Enabled
Bug
Performance
Security
Business Logic

Access your configuration settings here.

@pablopunk
pablopunk merged commit 1b89bb6 into main Jul 17, 2026
10 checks passed
@pablopunk
pablopunk deleted the agent/coder/pab-60-electron-windows-install branch July 17, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant