PAB-60: force Electron binary installation#137
Merged
Conversation
Co-authored-by: multica-agent <github@multica.ai>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces the Electron repair mechanism that previously relied on
pnpm rebuild electronwith a direct invocation of Electron’s owninstall.jsscript. By stripping theELECTRON_SKIP_BINARY_DOWNLOADandFORCE_NO_CACHEenvironment variables (case‑insensitive) and settingforce_no_cache=true, the installer now forces a fresh download of the Electron binary from the source every time the repair runs.The changes remove the
pnpmRebuildInvocationandrebuildElectronfunctions, replacing them withelectronInstallerEnvironment(which prepares the required installer environment) andinstallElectronBinary(which executes the install script). TheensureElectronAvailablefunction is updated accordingly to use the new installer path, and all related tests, imports, and exports are aligned with the new approach.This ensures a clean, up‑to‑date Electron binary installation, particularly addressing Windows environments where the previous pnpm‑based rebuild might have used cached or skipped downloads.