fix: Safari doesn't appear in app root search on macOS Sequoia#43
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 23 minutes and 33 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…pe checks On macOS Sequoia, Safari.app at /Applications is a symlink to /System/Cryptexes/App/System/Applications/Safari.app. Node's Dirent.isDirectory() returns false for symlinks (lstat semantics), so the old check !entry.isDirectory() silently dropped it during app scanning. Replace Dirent type checks with fs.stat() which follows all filesystem indirection (symlinks, firmlinks, etc.) and answers the correct question: does resolving this path yield a directory? Applied to both .app detection and recursion into subdirectories.
f7d8bb1 to
6f0ae3c
Compare
1 participant
Problem
Safari did not appear in the root search app list on macOS Sequoia (15.x).
Root cause
On macOS Sequoia,
/Applications/Safari.appis a symlink to/System/Cryptexes/App/System/Applications/Safari.app. The app scanner inscanMacAppsusedDirent.isDirectory()to filter entries, but Node'sisDirectory()useslstatsemantics — it returnsfalsefor symlinks, even ones pointing to directories. Safari was silently filtered out before the.appcheck.Fix
Replace
Direnttype checks (isDirectory()) withfs.stat()which follows all filesystem indirection (symlinks, firmlinks, etc.). This answers the correct architectural question: does resolving this path yield a directory? — regardless of the immediate filesystem entry type.Applied to both
.appdetection and recursion into subdirectories, making the scanner robust against any future indirection types Apple introduces.Verification
pnpm build✓pnpm typecheck✓fs.statcorrectly resolves the Safari symlink