Extend the CI matrix to PHP 8.3, 8.4 and 8.5 - #10
Merged
Merged
Conversation
Follows on from #9, which added the workflow with 7.4 through 8.2. Adds the three current releases, so the matrix now runs 7.4, 8.0, 8.1, 8.2, 8.3, 8.4 and 8.5. Verified against a clean checkout: fresh composer install plus the full suite on PHP 8.5.10 exits 0 (184 tests, 511 assertions). The 14 warnings for @expectedException-style annotations deprecated in PHPUnit 8 are unchanged and do not fail the build. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#9 landed the workflow running 7.4 through 8.2. This adds the three current releases, so the matrix is 7.4 / 8.0 / 8.1 / 8.2 / 8.3 / 8.4 / 8.5.
Test plan
Fresh
composer installplus the full suite on PHP 8.5.10 from a clean checkout of master: exits 0, 184 tests / 511 assertions. The 14 warnings for@expectedException-style annotations deprecated in PHPUnit 8 are unchanged and don't fail the build. 8.3 and 8.4 get their first run here.PHPUnit 8.5 still works on 8.4+, but emits "implicitly nullable parameter" deprecations from its own vendor code. They're raised at bootstrap and don't affect the exit code. Clearing both those and the annotation warnings means moving to PHPUnit 9+, which is a separate change.
buildwill fail as before — legacy CircleCI config, unrelated.🤖 Generated with Claude Code