DIAGNOSTIC: Windows hook spawn timing (do not merge) - #2
Closed
packetloss404 wants to merge 5 commits into
Closed
Conversation
Temporary instrumentation, not for merge. Gives every Windows hook test a 120s budget so the runner reports what the hook actually costs instead of truncating it at the budget, and adds a tiered measurement that separates bare CreateProcess from PowerShell startup from stdin plumbing from the internal/hooks wrapper. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
go test discards a passing package's stderr, which hid the numbers on exactly the runs that succeeded. Record to a file instead, and probe a bare CreateProcess and a cold PowerShell immediately before the first hook so machine contention can be told apart from interpreter start-up. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Owner
Author
|
Diagnosis confirmed; closing the instrumentation. The measurements it produced are in the fix at #3. First The branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary instrumentation to confirm the diagnosis for the flaky
TestRunUserPromptSubmit_CollectsStdoutontest (windows-latest).Not for merge. Will be closed once the numbers are collected.
🤖 Generated with Claude Code