fix stale working directory on agent re-runs - #489
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the fork_and_prepare_dist_git function to wipe the entire JIRA issue working directory before starting, replacing the previous behavior of only deleting the specific package directory. A new unit test was added to verify this cleanup. Feedback highlights a critical security vulnerability regarding path traversal if the JIRA issue identifier is malformed, and raises concerns about the potential for data loss if multiple packages share the same JIRA issue directory.
Wipe the entire per-issue working directory at the start of fork_and_prepare_dist_git so re-runs for the same JIRA issue don't hit stale state from a previous attempt. Co-authored-by: Cursor <cursoragent@cursor.com>
TomasKorbar
self-requested a review
May 15, 2026 14:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wipe the entire per-issue working directory at the start of fork_and_prepare_dist_git so re-runs for the same JIRA issue don't hit stale state from a previous attempt.