Skip to content

feat(sentry): wrap runs into Sentry transactions - #580

Merged
mfocko merged 2 commits into
packit:mainfrom
mfocko:feat/jira-ticket-in-sentry
Jun 9, 2026
Merged

feat(sentry): wrap runs into Sentry transactions#580
mfocko merged 2 commits into
packit:mainfrom
mfocko:feat/jira-ticket-in-sentry

Conversation

@mfocko

@mfocko mfocko commented Jun 9, 2026

Copy link
Copy Markdown
Member

• Should provide better UX with Sentry events
• Also it should be possible to query Sentry logs and events by the Jira
ticket

@mfocko mfocko self-assigned this Jun 9, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the jira_issue_context context manager with start_transaction in ymir/agents/observability.py to integrate Sentry transaction tracking across various agents (backport, preliminary testing, rebase, rebuild, and triage). The feedback recommends using sentry_sdk.start_transaction as a context manager to ensure transactions are properly finished and errors are reported even if exceptions occur, while also safely handling cases where the workflow parameter is None.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread ymir/agents/observability.py Outdated
mfocko added 2 commits June 9, 2026 13:05
• Should provide better UX with Sentry events
• Also it should be possible to query Sentry logs and events by the Jira
  ticket

Signed-off-by: Matej Focko <mfocko@packit.dev>
It appears that the process that loads the agent as a module results in
a logger name consisting of ‹__main__›, therefore switch to the filename
instead of the name of the module.

Signed-off-by: Matej Focko <mfocko@packit.dev>
@mfocko
mfocko force-pushed the feat/jira-ticket-in-sentry branch from ef0451b to 1409a6d Compare June 9, 2026 11:06
@mfocko
mfocko merged commit 46528e7 into packit:main Jun 9, 2026
9 checks passed
@mfocko
mfocko deleted the feat/jira-ticket-in-sentry branch June 9, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants