Skip to content

Improvements to single Jira, single patch, multiple CVE commits#655

Merged
antbob merged 4 commits into
packit:mainfrom
antbob:one_backport_many_cves_fixes
Jul 8, 2026
Merged

Improvements to single Jira, single patch, multiple CVE commits#655
antbob merged 4 commits into
packit:mainfrom
antbob:one_backport_many_cves_fixes

Conversation

@antbob

@antbob antbob commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

This is a followup to #631 addressing various review comments.

@antbob
antbob requested a review from nforro July 6, 2026 13:40

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates patch naming guidelines for multiple CVEs, adds the cve_id field to several data models, and refactors the git_log_search tool to search and report on each term individually. The feedback suggests improving the search tool by implementing case-insensitive matching and deduplicating search terms, along with adding corresponding test coverage.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread ymir/tools/unprivileged/wicked_git.py
Comment thread ymir/tools/unprivileged/tests/unit/test_wicked_git.py
@antbob

antbob commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator Author

@nforro this should address your review comments in #631

also, you were also right to question GitLogSearchTool. under closer examination it appears that it went thru some changes but that left it kinda half-baked so this patch hopefully addresses that as well.

nforro
nforro previously approved these changes Jul 7, 2026

@nforro nforro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This should probably be updated as well:

cve_id: str | None = Field(
default=None,
description="CVE identifier from the issue summary (e.g. 'CVE-2024-1234')",
)

Comment thread ymir/agents/prompts/backport/instructions.j2

@nforro nforro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants