feat(autopilot:playbooks-guidance): phase 2 — field hints & inline field-path validation - #71
Merged
Merged
Conversation
…eld-path validation
Frontend guidance (ADR-006):
- PlaybookFieldHints.tsx: collapsible per-field schema guide (role, tasks, loop,
tools_policy, context_spec, output_contract, provider_overlays) documenting the
tool-ceiling narrow-only rule and the trusted-vars/untrusted-context split;
auto-expands and highlights the offending field.
- PlaybookEditor: parsePlaybookError() renders the phase-0 field-path 422 inline
against the offending field; <root> shown as a document-level structure problem.
- Code-token lists injected via i18next interpolation values (kept out of
translatable strings); new keys translated into all 26 locales,
{{vars}}/{{values}}/{{kinds}}/{{field}} verified intact; types.ts regenerated.
Tests: 12 PlaybookEditor specs (3 new) + full suite (917 pass). i18n
--check-missing clean + coverage 100%. type-check/lint/format-check clean.
Adversarial review: 1 finding (<root> highlighted nothing) fixed + covered.
Owner
Author
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
📊 Coverage Report
Coverage Thresholds
Coverage reports generated by CI workflow |
pacphi
added a commit
that referenced
this pull request
Jul 1, 2026
* chore(autopilot:playbooks-guidance): promote plan to active pipeline + seed ledger Retires the shipped remediation-model-catalog pipeline (survives in git history and its ledger). Seeds record 0 of the playbooks-guidance session ledger. pr_ci mode, base=develop, trunk=main, 4 phases. * feat(autopilot:playbooks-guidance): phase 0 complete — gate PASSED (#69) Embedded playbook endpoint + schema-aware field-path validation (ADR-006). All required CI checks green: CI Success, Backend Build/Lint/Unit(SQLite)/Integration(PostgreSQL)/Coverage/Security, frontend + i18n. Adversarial review: 2 findings fixed. * feat(autopilot:playbooks-guidance): phase 1 complete — gate PASSED (#70) Load built-in default + duplicate + preview pills; embedded endpoint wired; all i18n keys translated into 26 locales + types.ts regenerated. All required CI green (CI Success, Frontend Build/Lint, Validate React Translations, backend). Adversarial review: bogus locale dir fixed. * feat(autopilot:playbooks-guidance): phase 2 complete — gate PASSED (#71) Per-field schema hints + inline field-path validation errors; 27-locale i18n with interpolation-protected code tokens + types.ts regen. All required CI green (CI Success, Frontend Build/Lint, Validate React Translations, backend). Adversarial review: <root> error handling fixed. * feat(autopilot:playbooks-guidance): phase 3 complete — gate PASSED (#72) Docs (PLAYBOOKS.md) + preview no-model-call integration test. All required CI green after one rustfmt fix (CI Success, Backend Lint/Build/Integration(PostgreSQL), frontend, docs lint). Feature complete — all 4 phases shipped. * chore(autopilot:playbooks-guidance): cross-phase optimization — gate PASSED (#73) Shared invalid_playbook() 422 helper (create/update dedup). All required CI green. * fix(remediation): refresh default model choices per config/models.yaml The playbook embedded default overlays and the provider DEFAULT_MODEL fallbacks held out-of-date model ids. Update both to current catalog choices: - claude: claude-sonnet-4-6 -> claude-sonnet-5 - gemini: gemini-2.0-flash -> gemini-2.5-flash (repriced 0.0003/0.0025 per 1k) - ollama: qwen2.5-coder -> qwen3-coder:30b-a3b-q4_K_M (runnable Ollama tag) Updates crates/ampel-worker/playbooks/default.yaml (UI-visible overlays) and the claude/gemini/ollama provider DEFAULT_MODEL constants (runtime fallback), plus the gemini cost model + its two pricing tests to match 2.5-flash rates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated phase-2 run of the
playbooks-guidanceautopilot pipeline (ADR-006). Frontend only.Deliverables
PlaybookFieldHints— a collapsible per-field schema guide next to the YAML editor documenting every playbook field, including the ADR-006 tool-ceiling narrow-only rule and the trusted-vars / untrusted-context split. Auto-expands and highlights the offending field on a validation error.parsePlaybookError()turns the phase-0 field-path422(invalid playbook \`:) into a structured error rendered against the offending field. Document-level` errors are shown as a "playbook structure" problem, not a fake field.remediation:playbooks.*keys translated into all 26 locales viaampel-i18n-builder. Code-token lists (enum values, provider kinds, trusted vars) are injected via i18next interpolation values so they never reach the translator;{{vars}}/{{values}}/{{kinds}}/{{field}}verified intact across all 27 locales.types.tsregenerated.DoD evidence
node scripts/i18n-coverage-report.js --check-missing→ no missing keysnode scripts/i18n-coverage-report.js --check --min-coverage 95→ 100%, all locales passmake test-frontend→ 917 passed / 6 skipped (incl. field-guide render + field-path +<root>structure-error specs)make lint-frontend✓ ·pnpm type-check✓ ·make format-check✓types.tsin sync.Notes
Adversarial review caught that a
<root>document-level error auto-expanded the guide while highlighting nothing — fixed to render a structure-level message and covered with a spec.