Skip to content

chore(autopilot:playbooks-guidance): cross-phase optimization #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pacphi merged 1 commit into from
Jul 1, 2026
Merged

chore(autopilot:playbooks-guidance): cross-phase optimization #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions crates/ampel-api/src/handlers/remediation_playbooks.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,13 @@ pub struct PreviewResponse {
pub allowed_tools: Vec<String>,
}

/// Map a playbook schema-validation failure to a `422` naming the offending
/// field path (ADR-006). Shared by create and update so the wire format stays a
/// single source of truth.
fn invalid_playbook(e: ampel_worker::services::playbook::PlaybookSchemaError) -> ApiError {
ApiError::unprocessable_entity(format!("invalid playbook `{}`: {}", e.field, e.message))
}

// ============================================================================
// Scope / ownership authorization
// ============================================================================
Expand Down Expand Up @@ -387,9 +394,8 @@ pub async fn create_playbook(

// Lint: schema-aware validation with a field-path diagnostic (ADR-006), so
// the client learns *which* field is wrong (e.g. `loop.max_iterations`).
ampel_worker::services::playbook::Playbook::validate_yaml(&req.content).map_err(|e| {
ApiError::unprocessable_entity(format!("invalid playbook `{}`: {}", e.field, e.message))
})?;
ampel_worker::services::playbook::Playbook::validate_yaml(&req.content)
.map_err(invalid_playbook)?;

let now = Utc::now();
let model = remediation_playbook::ActiveModel {
Expand Down Expand Up @@ -434,9 +440,8 @@ pub async fn update_playbook(
let row = load_writable(&state, auth.user_id, id).await?;

if let Some(content) = &req.content {
ampel_worker::services::playbook::Playbook::validate_yaml(content).map_err(|e| {
ApiError::unprocessable_entity(format!("invalid playbook `{}`: {}", e.field, e.message))
})?;
ampel_worker::services::playbook::Playbook::validate_yaml(content)
.map_err(invalid_playbook)?;
}

let mut active: remediation_playbook::ActiveModel = row.into();
Expand Down