Skip to content

Conversation

@konalegi
Copy link

Add buildUrl parameter for the pact publication function. Follow-up for #352

@konalegi konalegi marked this pull request as ready for review December 10, 2021 15:09
@konalegi konalegi mentioned this pull request Dec 10, 2021
2 tasks
@TimothyJones
Copy link
Contributor

TimothyJones commented Dec 13, 2021

Thanks for this!

Two small issues:

  1. The commit message here will appear in the release notes - However, this message currently isn't suitable for the release notes as it's a bit cryptic. (see our instructions here: https://github.com/pact-foundation/pact-js-core/blob/master/CONTRIBUTING.md#release-notes for guidelines).

Could you choose one of:

  • Force push (or otherwise resubmit) with a release-notes appropriate message (if you're not sure what to put, I think something like "feat: Add buildUrl option to Verifier API")
  • Let us squash merge it with a new message (if we do this, you don't get appropriately marked as a contributor, I think)
  1. Could you add the new option to the documentation in the readme please?

@TimothyJones
Copy link
Contributor

Also, it's currently failing the prettier format check step. You can fix this with npm run format:fix and committing the result.

@konalegi konalegi force-pushed the feat/add-build-url-on-pact-publish branch from 721c680 to 35fc984 Compare December 13, 2021 06:01
@konalegi konalegi force-pushed the feat/add-build-url-on-pact-publish branch from 35fc984 to 58be64a Compare December 13, 2021 06:11
@konalegi
Copy link
Author

konalegi commented Dec 13, 2021

@TimothyJones thanks for your review.

  • Added documentation
  • Fixed prettier
  • Updated commit message but feel free to update it before merging.

Thanks!

@TimothyJones TimothyJones merged commit 7ed93b4 into pact-foundation:master Dec 14, 2021
@TimothyJones
Copy link
Contributor

Thanks very much! I'll release this now

@TimothyJones
Copy link
Contributor

This is now released in pact-core@13.4.0 and pact-node@10.16.0

Thanks again for the PR! Welcome to the list of pact-js contributors :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants