Skip to content

Conversation

@YOU54F
Copy link
Member

@YOU54F YOU54F commented Oct 31, 2025

https://pact-foundation.github.io/pact-python/API/

and

https://pact-foundation.github.io/pact-python/api/

don't route to the same page, unsure if it should, so update link

Copilot AI review requested due to automatic review settings October 31, 2025 15:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a case sensitivity issue in the API documentation link. The URL was pointing to /API/ (uppercase) when it should point to /api/ (lowercase), as these resolve to different pages.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52%. Comparing base (253e972) to head (e98cf1a).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1316   +/-   ##
====================================
  Coverage    52%     52%           
====================================
  Files        31      31           
  Lines      3688    3688           
====================================
  Hits       1925    1925           
  Misses     1763    1763           
Flag Coverage Δ
tests 52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JP-Ellis JP-Ellis merged commit 723a031 into main Nov 2, 2025
59 checks passed
@JP-Ellis JP-Ellis deleted the docs/update_api_link branch November 2, 2025 04:20
@JP-Ellis
Copy link
Contributor

JP-Ellis commented Nov 2, 2025

Thanks for catching that! I didn't realise it was case sensitive, and I think I changed the convention early one to default to kebab-case for the URLs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants