Skip to content

Conversation

@JP-Ellis
Copy link
Contributor

Schema Store seem to have changed the URL; and while the previous
'json' subdomain should redirect, it seems flakey and results in
failures in CI.

In addition, removing the Taplo pre-commit hook as it is no longer maintained.

Schema Store seem to have changed the URL; and while the previous
'json' subdomain should redirect, it seems flakey and results in
failures in CI.

In addition, removing the Taplo pre-commit hook as it is no longer maintained.
Copilot AI review requested due to automatic review settings November 10, 2025 05:37
@JP-Ellis JP-Ellis self-assigned this Nov 10, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates JSON schema URLs from the deprecated json.schemastore.org subdomain to www.schemastore.org to address CI failures caused by flaky redirects, and removes the unmaintained Taplo pre-commit hook.

  • Schema URLs updated across all configuration files to use the stable www.schemastore.org domain
  • Taplo pre-commit hooks removed from the configuration

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/.ruff.toml Updated Ruff schema URL to use www subdomain
pyproject.toml Updated pyproject schema URL to use www subdomain
pact-python-ffi/tests/.ruff.toml Updated Ruff schema URL to use www subdomain
pact-python-ffi/pyproject.toml Updated pyproject schema URL to use www subdomain
pact-python-ffi/cliff.toml Updated cliff schema URL to use www subdomain
pact-python-cli/tests/.ruff.toml Updated Ruff schema URL to use www subdomain
pact-python-cli/pyproject.toml Updated pyproject schema URL to use www subdomain
pact-python-cli/cliff.toml Updated cliff schema URL to use www subdomain
examples/http/requests_and_fastapi/pyproject.toml Updated pyproject schema URL to use www subdomain
examples/http/aiohttp_and_flask/pyproject.toml Updated pyproject schema URL to use www subdomain
examples/.ruff.toml Updated Ruff schema URL to use www subdomain
docs/scripts/.ruff.toml Updated Ruff schema URL to use www subdomain
cliff.toml Updated cliff schema URL to use www subdomain
.pre-commit-config.yaml Removed deprecated Taplo pre-commit hooks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JP-Ellis JP-Ellis enabled auto-merge (rebase) November 10, 2025 05:38
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52%. Comparing base (6f2819b) to head (5ca0c05).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@         Coverage Diff          @@
##           main   #1326   +/-   ##
====================================
  Coverage    52%     52%           
====================================
  Files        31      31           
  Lines      3688    3688           
====================================
  Hits       1925    1925           
  Misses     1763    1763           
Flag Coverage Δ
tests 52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JP-Ellis JP-Ellis merged commit b031eb7 into main Nov 10, 2025
59 checks passed
@JP-Ellis JP-Ellis deleted the chore/fix-json-schema-url branch November 10, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants