feat: add 'and' matcher #1348
feat: add 'and' matcher #1348
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an AndMatcher class that enables combining multiple matchers using logical AND operations, implemented through Python's & operator overloading. This feature is foundational for an upcoming fix to matching rules serialization.
Key Changes:
- Added
has_value()method toAbstractMatcherto check for value presence - Implemented
__and__()operator overloading to combine matchers - Introduced
AndMatcherclass for managing combined matcher logic
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1348 +/- ##
======================================
Coverage ? 51%
======================================
Files ? 31
Lines ? 3723
Branches ? 0
======================================
Hits ? 1935
Misses ? 1788
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JP-Ellis
force-pushed
the
feat/and-matcher
branch
from
e5f8b46 to
e02615a
Compare
The `AndMatcher` allows for matchers to be combined. This is achieved in practice through the overloaded `&` operator. Signed-off-by: JP-Ellis <josh@jpellis.me>
JP-Ellis
force-pushed
the
feat/and-matcher
branch
from
e02615a to
65a12c9
Compare
📝 Summary
The
AndMatcherallows for matchers to be combined. This is achieved in practice through the overloaded&operator.🚨 Breaking Changes🔥 Motivation
Not only is it useful, but it is also necessary for an upcoming fix to the matching rules serialisation.
🔨 Test Plan
None so far, but will be tested in upcoming PR.
🔗 Related issues/PRs