chore: don't except AssertionError #1373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JP-Ellis <josh@jpellis.me>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the --rerun-except=AssertionError flag from pytest configuration to allow flaky tests that fail with AssertionError to be automatically retried.
- Removes the exclusion of
AssertionErrorfrom pytest's rerun mechanism
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1373 +/- ##
====================================
Coverage 51% 51%
====================================
Files 31 31
Lines 3729 3729
====================================
Hits 1938 1938
Misses 1791 1791
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Remove the rerun exception for
AssertionError🚨 Breaking Changes🔥 Motivation
Some flaky tests result in
AssertionError(not justRuntimeError).🔨 Test Plan
CI
🔗 Related issues/PRs