Skip to content

Conversation

@copalco
Copy link
Contributor

@copalco copalco commented Sep 10, 2020

There is a bug in a pact verifier which prohibits use of unauthenticated pact-broker

@copalco copalco changed the title Allow to use unauthenticated brokers feat(verifier): allow to use unauthenticated brokers Sep 10, 2020
@elliottmurray
Copy link
Contributor

Can you add some asserts around line 87-ish. There are some examples in that file but at the moment you don't seem to actually assert anything. Otherwise LGTM.

Though I didn't actually know you could use broker without auth?

@copalco
Copy link
Contributor Author

copalco commented Sep 10, 2020

@elliottmurray I don't assert anything, because this test was raising an error, before I applied the change, so we are implicitly asserting that it's working fine now.

@copalco
Copy link
Contributor Author

copalco commented Sep 10, 2020

@elliottmurray Yes we have a broker without authentication configured and it's working fine.

@elliottmurray
Copy link
Contributor

I accept that fixes this immediate problem but the test should describe the expected behaviour that we make a process call with this in place. See line 138. You should be able to copy/paste with a small modification or 2.

@copalco
Copy link
Contributor Author

copalco commented Sep 10, 2020

@elliottmurray I added assertion that popen process was called with expected parameters

@elliottmurray
Copy link
Contributor

Thanks

@elliottmurray elliottmurray merged commit 1192bd6 into pact-foundation:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants