refactor: make examples accept addresses via CLI args and env vars#68
Merged
Conversation
- Add --address CLI option to all network-dependent examples - Support JSONRPC_ADDRESS, GRPC_ADDRESS, ZMQ_ADDRESS env vars - Remove hardcoded default addresses - Flatten structure: parse args in __main__, pass addr directly - Add docstrings with usage instructions - Update GitHub Actions workflow to use secrets + daily schedule
themantre
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored all network-dependent examples to accept addresses via
--addressCLI option and environment variables, instead of hardcoded defaults.Changes
example_decode_block.py,example_jsonrpc_get_blockchain_info.py,example_jsonrpc_get_node_info.py,example_grpc_get_blockchain_info.py,example_grpc_get_node_info.py,example_zmq.pyJSONRPC_ADDRESS,GRPC_ADDRESS,ZMQ_ADDRESS(priority:--addressflag > env var, no hardcoded fallback)__main__and passed to work functionscron: 0 0 * * *)Secrets to add in GitHub
EXAMPLES_JSONRPC_ADDRESSEXAMPLES_GRPC_ADDRESSEXAMPLES_ZMQ_ADDRESS