Conversation
dmnplb
added
dependencies
Design System
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
dmnplb
changed the title
reanimated and react-native-svg dependenciesreanimated, react-native-svg and react-native-skia dependencies
gispada
approved these changes
Apr 9, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 11, 2025
…ed to render `Avatar` (#6856) > [!important] > This PR depends on: > * #6844 ## Short description This PR replaces the local `BannerErrorState` with the one migrated in the `io-app-design-system`. The replacement comes with an additional support for dark mode. ## List of changes proposed in this pull request - Update `io-app-design-system` to `5.3.5` - Remove local `BannerErrorState` - Update types used to render `Avatar` component - Add explicit sizes to `Avatar` source prop to avoid a critical Android runtime error ## How to test Check all the areas where `Avatar` or `AvatarSearch` is used and check if everything is okay --------- Co-authored-by: Emanuele Dall'Ara <71103219+LeleDallas@users.noreply.github.com> Co-authored-by: Gianluca Spada <gianluca.spada@spindox.it>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
This PR depends on:
reanimatedto3.17.1io-app-design-system#443Short description
This PR updates
reanimated,react-native-svgandreact-native-skiadependencies. Thanks to the DS update, it also aligns other dependencies (such asreact-native-safe-area-context, for example) in both repositories.List of changes proposed in this pull request
io-app-design-systemto5.3.1reanimated,react-native-svgandreact-native-skiadependenciesDSButtonsandDSLoadersto reflect latest changesHow to test
At the moment, please test the PR pointing to the relative PR in the
io-app-design-systempackage.