Skip to content

Comments

feat: [IOBP-1419] CDC activation screen#6848

Merged
LeleDallas merged 23 commits intomasterfrom
IOBP-1419
Apr 10, 2025
Merged

feat: [IOBP-1419] CDC activation screen#6848
LeleDallas merged 23 commits intomasterfrom
IOBP-1419

Conversation

@LeleDallas
Copy link
Contributor

@LeleDallas LeleDallas commented Mar 26, 2025

Warning

This PR depends on pagopa/io-dev-api-server#475

Short description

This pull request introduces a new feature for CDC (Carta della Cultura) bonus activation and integrates it into the existing navigation structure

List of changes proposed in this pull request

  • Created a new screen component CdcBonusRequestInformationTos for displaying CDC bonus information
  • Added a new navigator CdcNavigator to handle CDC-related navigation
  • Added a new component ServiceDetailsScreenCdc to display CDC-specific service details
  • Created a hook useSpecialCtaCdc to handle CDC activation and deactivation logic
  • Update isCdcEnabledSelector to isCdcAppVersionSupportedSelector to check the cdcV2 min_app_version

How to test

  • From Servizi search Carta della Cultura item and press on it
  • Press on Richiedi Carta della Cultura
  • Ensure that all tos information are aligned with design requirements

Preview

Screen.Recording.2025-03-26.at.15.07.51.mov

@github-actions
Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 68.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 51.30%. Comparing base (df3f44c) to head (ec59bbb).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/bonus/cdc/hooks/useSpecialCtaCdc.tsx 75.00% 5 Missing ⚠️
ts/store/reducers/backendStatus/remoteConfig.ts 20.00% 4 Missing ⚠️
ts/navigation/AuthenticatedStackNavigator.tsx 0.00% 3 Missing ⚠️
...tails/components/ServiceDetailsScreenComponent.tsx 0.00% 2 Missing ⚠️
...tivation/screens/CdcBonusRequestInformationTos.tsx 85.71% 1 Missing ⚠️
ts/features/bonus/cdc/navigation/navigator.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6848      +/-   ##
==========================================
+ Coverage   51.26%   51.30%   +0.03%     
==========================================
  Files        1623     1628       +5     
  Lines       33705    33753      +48     
  Branches     7656     7617      -39     
==========================================
+ Hits        17279    17317      +38     
- Misses      16372    16394      +22     
+ Partials       54       42      -12     
Files with missing lines Coverage Δ
ts/features/bonus/cdc/navigation/routes.ts 100.00% <100.00%> (ø)
...ures/bonus/common/screens/AvailableBonusScreen.tsx 7.69% <ø> (ø)
...ces/details/components/ServiceDetailsScreenCdc.tsx 100.00% <100.00%> (ø)
ts/navigation/params/AppParamsList.ts 100.00% <ø> (ø)
ts/store/reducers/__mock__/backendStatus.ts 100.00% <ø> (ø)
...tivation/screens/CdcBonusRequestInformationTos.tsx 85.71% <85.71%> (ø)
ts/features/bonus/cdc/navigation/navigator.tsx 66.66% <66.66%> (ø)
...tails/components/ServiceDetailsScreenComponent.tsx 9.09% <0.00%> (-2.03%) ⬇️
ts/navigation/AuthenticatedStackNavigator.tsx 15.00% <0.00%> (-2.65%) ⬇️
ts/store/reducers/backendStatus/remoteConfig.ts 68.42% <20.00%> (-0.63%) ⬇️
... and 1 more

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb3ebbd...ec59bbb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants