Skip to content

Comments

fix: [IOCOM-2284] Proper tracking of the CTA decoding failure analytics #6850

Merged
Vangaorth merged 14 commits intomasterfrom
IOCOM-2284_frontMatterAnalytics
Mar 31, 2025
Merged

fix: [IOCOM-2284] Proper tracking of the CTA decoding failure analytics #6850
Vangaorth merged 14 commits intomasterfrom
IOCOM-2284_frontMatterAnalytics

Conversation

@Vangaorth
Copy link
Contributor

@Vangaorth Vangaorth commented Mar 26, 2025

Short description

This PR fixes the tracking of the CTA decoding failure event, which was sent even for messages and services with no CTAs.

List of changes proposed in this pull request

  • Such event is sent only when an exception or a failure occurs
  • Since it is shared, every reference to MessageCTA has been renamed to LocalizedCTAs

How to test

CI tests should succeed. Using the io-dev-api-server, check that the event is not raised for normal messages.

@github-actions
Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 98.46154% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.11%. Comparing base (5810d2d) to head (6ebf0cb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../services/details/screens/ServiceDetailsScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6850      +/-   ##
==========================================
+ Coverage   51.09%   51.11%   +0.02%     
==========================================
  Files        1613     1613              
  Lines       33666    33680      +14     
  Branches     7653     7658       +5     
==========================================
+ Hits        17200    17214      +14     
+ Misses      16412    16411       -1     
- Partials       54       55       +1     
Files with missing lines Coverage Δ
ts/features/messages/analytics/index.ts 45.19% <100.00%> (ø)
...nents/MessageDetail/MessageDetailsStickyFooter.tsx 82.35% <ø> (ø)
.../messages/components/MessageDetail/detailsUtils.ts 25.00% <ø> (ø)
ts/features/messages/saga/handleLoadMessageData.ts 91.74% <100.00%> (+0.07%) ⬆️
...features/messages/screens/MessageDetailsScreen.tsx 75.43% <100.00%> (ø)
ts/features/messages/utils/ctas.ts 98.09% <100.00%> (+0.26%) ⬆️
ts/features/pn/utils/index.ts 97.91% <ø> (ø)
ts/features/services/details/utils/index.tsx 59.09% <ø> (ø)
ts/types/LocalizedCTAs.ts 100.00% <100.00%> (ø)
.../services/details/screens/ServiceDetailsScreen.tsx 8.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5810d2d...6ebf0cb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@forrest57 forrest57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vangaorth Vangaorth enabled auto-merge March 31, 2025 10:38
@Vangaorth Vangaorth added this pull request to the merge queue Mar 31, 2025
Merged via the queue into master with commit 244e7c4 Mar 31, 2025
22 checks passed
@Vangaorth Vangaorth deleted the IOCOM-2284_frontMatterAnalytics branch March 31, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants