fix: [IOCOM-2284] Proper tracking of the CTA decoding failure analytics #6850
Merged
fix: [IOCOM-2284] Proper tracking of the CTA decoding failure analytics #6850
Conversation
Contributor
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Contributor
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6850 +/- ##
==========================================
+ Coverage 51.09% 51.11% +0.02%
==========================================
Files 1613 1613
Lines 33666 33680 +14
Branches 7653 7658 +5
==========================================
+ Hits 17200 17214 +14
+ Misses 16412 16411 -1
- Partials 54 55 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This PR fixes the tracking of the CTA decoding failure event, which was sent even for messages and services with no CTAs.
List of changes proposed in this pull request
How to test
CI tests should succeed. Using the io-dev-api-server, check that the event is not raised for normal messages.