fix(ci): add rustup target add for workspace-pinned toolchain in binary-release#1092
Merged
Conversation
…mpiles The dtolnay/rust-toolchain action's `targets:` parameter installs the target on the action-resolved toolchain, but rust-toolchain.toml in the workspace pins channel 1.93.0 which overrides it for any cargo invocation in the tree. Native cross-compiles (x86_64-musl) consequently fail with `can't find crate for core` — the pinned toolchain has no musl target installed, even though the action thinks it does. Mirrors the fix already merged in paiml/forjar PR #124 and paiml/bashrs PR #200 (same root cause across all paiml workspaces with a pinned rust-toolchain.toml). Without this fix, v0.31.2 backfill failed x86_64-musl while the other 3 targets succeeded — exactly the symptom forjar exhibited before #124. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
targets:parameter installs targets on the action-resolved toolchain, butrust-toolchain.tomlpins channel 1.93.0 which overrides it for any cargo invocation in the workspace.can't find crate for core— the pinned toolchain has no musl target.Why
Same root cause as the fix already merged in paiml/forjar PR #124 and paiml/bashrs PR #200. All paiml workspaces with a pinned
rust-toolchain.tomlexhibit the same failure mode for native cross-compiles inbinary-release.yml.Evidence
The v0.31.2 backfill ran the unfixed workflow:
can't find crate for coreOnce this PR merges I'll re-trigger the v0.31.2 backfill via
gh workflow run "Binary Release" -f tag=v0.31.2to attach the missing musl tarball.Test plan
Editadds the step in the same place as the bashrs PR (between the dtolnay action andInstall musl tools)!matrix.crossso it only runs for native targetsbinary-releaseworkflow on this PR completes (workflow runs onrelease: publishedandworkflow_dispatchonly, so PR CI doesn't exercise it directly — verification happens at the next backfill)🤖 Generated with Claude Code