fix(release): rustup target add to defeat workspace toolchain pin#124
Merged
Conversation
rust-toolchain.toml pins channel 1.93.0 with no target list. The
dtolnay/rust-toolchain action's `targets:` parameter installs the
target into the action's chosen toolchain, but cargo running inside
the workspace honors rust-toolchain.toml and ends up with a toolchain
that's missing x86_64-unknown-linux-musl — so the native musl build
fails mid-compile with "can't find crate for core".
Add an explicit `rustup target add ${{ matrix.target }}` after the
dtolnay step so the pinned toolchain gets the target too. Skip when
matrix.cross=true since cross builds inside its own Docker image and
doesn't need host targets.
Refs: forjar v1.3.0 backfill x86_64-musl failure (run 25003882860).
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
forjar v1.3.0 backfill ran 4 jobs; 3 succeeded but x86_64-unknown-linux-musl failed mid-build with:
Root cause (Five Whys):
Fix: add an explicit `rustup target add ${{ matrix.target }}` step after the dtolnay step. Skip when matrix.cross=true (cross uses its own Docker image).
Test plan
🤖 Generated with Claude Code