Skip to content

fix(web): 대시보드 조직 요약 카드 개선 - #85

Merged
meteorqz6 merged 4 commits into
developfrom
fix/dashboard-organization-summary-card
Jun 25, 2026
Merged

fix(web): 대시보드 조직 요약 카드 개선#85
meteorqz6 merged 4 commits into
developfrom
fix/dashboard-organization-summary-card

Conversation

@meteorqz6

@meteorqz6 meteorqz6 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

요약

  • 대시보드 조직 요약 카드가 실제 조직 조회 데이터를 표시하도록 수정했습니다.
  • 아이콘, 상태 배지, 운영 시간/휴무일 칩을 추가해 카드 가독성을 개선했습니다.
  • 조직 수정 페이지 설명 문구를 자연스럽게 다듬었습니다.

스크린샷

image

테스트

  • pnpm --filter @fragment/web typecheck
  • pnpm --filter @fragment/web lint

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@meteorqz6, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 33 minutes and 44 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f17c9330-4caa-4112-8316-af258ca02583

📥 Commits

Reviewing files that changed from the base of the PR and between 003f6c7 and cba1110.

📒 Files selected for processing (1)
  • apps/web/src/features/dashboard/components/mvp-dashboard-page.tsx

Walkthrough

대시보드 상단 요약이 조직 상세 조회 기반으로 바뀌고, 운영 시간과 매주 휴무가 비즈니스 시간 데이터에서 계산되어 렌더링된다. 하단 확정 스케줄 문구와 조직 수정 페이지 설명 문구도 함께 갱신됐다.

Changes

조직 스케줄 대시보드 갱신

Layer / File(s) Summary
요약 상수와 요일 라벨
apps/web/src/features/dashboard/components/mvp-dashboard-page.tsx
scheduleSummaryDAY_LABELS 기반 WEEKDAY_LABELS가 추가되어 대시보드에서 사용할 기본 문구와 요일 표기가 정리됐다.
조직 비즈니스 시간 파생
apps/web/src/features/dashboard/components/mvp-dashboard-page.tsx
useOrganizationQuery 결과의 businessHours로 운영 시간 문자열, 시간대별 요일 그룹, 휴무 요일 라벨을 계산하는 유틸과 폴백 상태 처리가 추가됐다.
대시보드 렌더링과 문구
apps/web/src/features/dashboard/components/mvp-dashboard-page.tsx, apps/web/src/features/organization/components/mvp-organization-edit-page.tsx
상단 요약이 조직명/상태 배지/수정 버튼과 운영 시간·휴무 카드로 바뀌고, 확정 스케줄 문구와 조직 편집 설명이 갱신됐다.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning 요약·스크린샷·테스트는 있으나 개요, 변경 사항, 변경 유형, 영향 범위, 체크리스트, 리뷰 포인트가 빠져 템플릿을 충분히 따르지 않습니다. 템플릿에 맞춰 개요(Closes #이슈), 변경 사항, 변경 유형, 영향 범위, 체크리스트, 리뷰 포인트를 보완해 주세요.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed 대시보드 조직 요약 카드 개선과 조회 기반 요약 UI 변경을 잘 반영한 제목입니다.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dashboard-organization-summary-card

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@meteorqz6 meteorqz6 changed the title Fix dashboard organization summary card 대시보드 조직 요약 카드 개선 Jun 25, 2026
@meteorqz6 meteorqz6 changed the title 대시보드 조직 요약 카드 개선 fix(web): 대시보드 조직 요약 카드 개선 Jun 25, 2026
@meteorqz6 meteorqz6 self-assigned this Jun 25, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/web/src/features/dashboard/components/mvp-dashboard-page.tsx`:
- Line 218: The `md:grid-cols-[minmax(0,1fr)_minmax(260px,0.55fr)]` class in
`MvpDashboardPage` uses a forbidden arbitrary pixel value. Replace the `260px`
usage with a Tailwind default scale value or promote it to a reusable token in
`globals.css`, then update the grid utility to reference that token while
keeping the layout behavior intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4c23f8de-923c-4e63-a255-fcc52029126c

📥 Commits

Reviewing files that changed from the base of the PR and between 80565cc and 003f6c7.

📒 Files selected for processing (2)
  • apps/web/src/features/dashboard/components/mvp-dashboard-page.tsx
  • apps/web/src/features/organization/components/mvp-organization-edit-page.tsx

Comment thread apps/web/src/features/dashboard/components/mvp-dashboard-page.tsx Outdated
import { Building2, CalendarX, Clock, Download, Pencil } from "lucide-react";

import { AdminPageShell } from "@/components/layout/admin-page-shell";
import { Badge } from "@/components/ui/badge";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[질문]
프로젝트 기준상 UI 컴포넌트는 @moyeorak/design-system을 1순위로 사용하고, 디자인 시스템에도 Badge가 있는 것으로 알고 있습니다.
여기서 로컬 shadcn Badge를 사용한 이유가 에러 상태(확인 필요)처럼 디자인 시스템 Badge로 표현하기 어려운 상태 variant가 필요해서인지 확인 부탁드립니다. 특별한 이유가 없다면 기존 availability/schedules 화면처럼 디자인 시스템 Badge로 맞추는 것도 좋아 보입니다.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그 부분 인지하고 있습니다. 규모가 커지는 작업이라 후속 작업으로 리팩토링해야할 것 같아요!

@meteorqz6
meteorqz6 merged commit 9ac0576 into develop Jun 25, 2026
2 checks passed
@meteorqz6
meteorqz6 deleted the fix/dashboard-organization-summary-card branch June 25, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants