fix(web): 대시보드 조직 요약 카드 개선 - #85
Conversation
|
Warning Review limit reached
More reviews will be available in 33 minutes and 44 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Walkthrough대시보드 상단 요약이 조직 상세 조회 기반으로 바뀌고, 운영 시간과 매주 휴무가 비즈니스 시간 데이터에서 계산되어 렌더링된다. 하단 확정 스케줄 문구와 조직 수정 페이지 설명 문구도 함께 갱신됐다. Changes조직 스케줄 대시보드 갱신
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/web/src/features/dashboard/components/mvp-dashboard-page.tsx`:
- Line 218: The `md:grid-cols-[minmax(0,1fr)_minmax(260px,0.55fr)]` class in
`MvpDashboardPage` uses a forbidden arbitrary pixel value. Replace the `260px`
usage with a Tailwind default scale value or promote it to a reusable token in
`globals.css`, then update the grid utility to reference that token while
keeping the layout behavior intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 4c23f8de-923c-4e63-a255-fcc52029126c
📒 Files selected for processing (2)
apps/web/src/features/dashboard/components/mvp-dashboard-page.tsxapps/web/src/features/organization/components/mvp-organization-edit-page.tsx
| import { Building2, CalendarX, Clock, Download, Pencil } from "lucide-react"; | ||
|
|
||
| import { AdminPageShell } from "@/components/layout/admin-page-shell"; | ||
| import { Badge } from "@/components/ui/badge"; |
There was a problem hiding this comment.
[질문]
프로젝트 기준상 UI 컴포넌트는 @moyeorak/design-system을 1순위로 사용하고, 디자인 시스템에도 Badge가 있는 것으로 알고 있습니다.
여기서 로컬 shadcn Badge를 사용한 이유가 에러 상태(확인 필요)처럼 디자인 시스템 Badge로 표현하기 어려운 상태 variant가 필요해서인지 확인 부탁드립니다. 특별한 이유가 없다면 기존 availability/schedules 화면처럼 디자인 시스템 Badge로 맞추는 것도 좋아 보입니다.
There was a problem hiding this comment.
그 부분 인지하고 있습니다. 규모가 커지는 작업이라 후속 작업으로 리팩토링해야할 것 같아요!
요약
스크린샷
테스트