Skip to content

feat(web): 최소 인원 조건 API 연결 - #87

Merged
meteorqz6 merged 4 commits into
developfrom
feature/86-staffing-rules-web-api
Jun 25, 2026
Merged

feat(web): 최소 인원 조건 API 연결#87
meteorqz6 merged 4 commits into
developfrom
feature/86-staffing-rules-web-api

Conversation

@ehlung

@ehlung ehlung commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

개요

최소 인원 조건 화면을 API와 연결하고 저장/삭제 요청 상태와 폼 검증을 정리했습니다.

Closes #86


변경 사항

  • 최소 인원 조건 GET/POST/PATCH/DELETE API 클라이언트와 TanStack Query 훅 추가
  • 최소 인원 조건 화면을 목데이터 대신 API 응답 기준으로 렌더링
  • 저장/삭제 중 버튼 비활성화 및 실패 메시지 처리
  • 폼 검증을 React Hook Form + shared Zod 스키마 기준으로 정리

변경 유형

  • feat — 새로운 기능
  • fix — 버그 수정
  • refactor — 리팩터링 (기능 변경 없음)
  • test — 테스트 코드
  • perf — 성능 개선
  • docs — 문서 수정
  • chore — 빌드·설정 변경

영향 범위

  • webapps/web
  • apiapps/api
  • dbpackages/database
  • sharedpackages/shared
  • repo — 루트 설정·CI/CD·문서

테스트 방법

  1. pnpm --filter @fragment/web typecheck
  2. pnpm --filter @fragment/web lint
  3. pnpm --filter @fragment/web test
  4. pnpm --filter @fragment/web build
  5. pnpm --filter @fragment/api test
  6. pnpm format:check

체크리스트

  • CI (테스트 + 린트) 통과 확인
  • 관련 테스트 코드 작성 또는 업데이트
  • 상태 분류 규칙(서버/전역/로컬/폼 상태) 준수
  • 에러 처리 및 Fallback UI 확인 (해당 시)
  • API 명세 업데이트 (API 변경 시)
  • 공유 타입·스키마(packages/shared) 업데이트 (타입 변경 시)

스크린샷 / 영상

없음


리뷰 포인트

  • 최소 인원 조건 화면이 TanStack Query 서버 상태와 로컬 UI/폼 상태를 분리해서 사용하는지
  • 저장/삭제 pending 상태에서 중복 요청이 차단되는지
  • 폼 검증이 shared Zod 스키마 기준과 맞는지

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@ehlung, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 54 minutes and 2 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8f20de8d-3a57-4d43-8674-c7755318ff8e

📥 Commits

Reviewing files that changed from the base of the PR and between 0afc5d7 and 0b86f59.

📒 Files selected for processing (6)
  • apps/web/src/components/admin/crud-form-dialog.tsx
  • apps/web/src/components/common/delete-confirm-dialog.tsx
  • apps/web/src/features/staffing-rules/api/staffing-rules-api.ts
  • apps/web/src/features/staffing-rules/components/mvp-staffing-rules-page.tsx
  • apps/web/src/features/staffing-rules/queries/staffing-rules-queries.ts
  • apps/web/src/features/staffing-rules/queries/staffing-rules-query-keys.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/86-staffing-rules-web-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ehlung
ehlung force-pushed the feature/86-staffing-rules-web-api branch from a7b5153 to 0b86f59 Compare June 25, 2026 13:16
@meteorqz6
meteorqz6 merged commit a94919c into develop Jun 25, 2026
2 checks passed
@meteorqz6
meteorqz6 deleted the feature/86-staffing-rules-web-api branch June 25, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(web): 최소 인원 조건 API 연결

2 participants