Skip to content

test(gb-test-runner): migrate gbmicrotest to c-sp v7#263

Merged
pakitovic merged 2 commits into
mainfrom
codex/gbmicrotest-v7
Jun 18, 2026
Merged

test(gb-test-runner): migrate gbmicrotest to c-sp v7#263
pakitovic merged 2 commits into
mainfrom
codex/gbmicrotest-v7

Conversation

@pakitovic

Copy link
Copy Markdown
Owner

Summary

  • migrate the standalone gbmicrotest suite to the c-sp game-boy-test-roms v7.0 archive
  • keep only the new c-sp v7 gbmicrotest family after confirming the old DocBoy rows are green in the new family
  • disable no-clear-pass/debug, visual-fixture-candidate, and future VRAM-oracle rows with explicit comments
  • temporarily comment the gbmicrotest test-roms-extra lane while the v7 baseline remains intentionally red

Validation

  • cargo fmt-check
  • cargo test -p gb-test-runner real_gbmicrotest_suite_manifest_loads_v7_memory_byte_oracles
  • cargo rom-fetch gbmicrotest
  • cargo rom-suite gbmicrotest --suite gbmicrotest --boot-rom-dir /tmp/gbmicrotest-boot-rom → expected non-zero, 479/482 passed

Expected active failures remain visible for follow-up work:

  • halt_op_dupe_delay.gb
  • stat_write_glitch_l154_d.gb
  • mbc1_rom_banks.gb loader rejection

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e2f9cb80da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/gb-test-runner/data/gbmicrotest/gbmicrotest.suite.toml
@pakitovic
pakitovic merged commit de49cbf into main Jun 18, 2026
30 checks passed
@pakitovic
pakitovic deleted the codex/gbmicrotest-v7 branch June 18, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant