Create adapter for DebugModule to reduce boilerplate code#65
Closed
0legg wants to merge 2 commits intopalaima:masterfrom
0legg:feature/debug-module-adapter
Closed
Create adapter for DebugModule to reduce boilerplate code#650legg wants to merge 2 commits intopalaima:masterfrom 0legg:feature/debug-module-adapter
0legg wants to merge 2 commits intopalaima:masterfrom
0legg:feature/debug-module-adapter
Conversation
added 2 commits
June 15, 2016 11:35
Owner
|
Thanks for contributing! Could you another PR to point into |
Author
|
Created new PR #67 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few modules override all 7 methods of DebugModule, lot of them keep all lifecycle and visibility methods empty. So we can introduce abstract adapter class, which allow module developers keep their code clean of boilerplate.