Failure with union with single value.#44
Closed
jkozlowski wants to merge 1 commit into
Closed
Conversation
jkozlowski
commented
Jul 18, 2018
Contributor
Author
There was a problem hiding this comment.
This is where it fails
Contributor
There was a problem hiding this comment.
Seems like we're just not generating a correct builder method for unknown properties
Merged
ferozco
added a commit
that referenced
this pull request
Jul 18, 2018
Contributor
Author
|
Looks like the fix was merged? |
carterkozak
pushed a commit
to carterkozak/conjure-java
that referenced
this pull request
Dec 24, 2018
* wrapper * baseline * fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know the fix, but I thought I'd provide the failure case:
The code in this PR seems to fail to generate correct objects, @dansanduleac could someone have a look?