revert union changes#45
Merged
Merged
Conversation
dansanduleac
approved these changes
Jul 18, 2018
dansanduleac
suggested changes
Jul 18, 2018
|
|
||
| @Value.Derived | ||
| default String getterName() { | ||
| return asGetterName(fieldName().get()); |
Contributor
There was a problem hiding this comment.
With this refactor, asGetterName is now dead code
| @@ -160,3 +160,6 @@ types: | |||
| union: | |||
Contributor
There was a problem hiding this comment.
do we need this Union type at all, given that there is also a UnionTypeExample type that does a similar thing but with more variants?
Contributor
There was a problem hiding this comment.
Note: it's not used anywhere
Contributor
There was a problem hiding this comment.
Left it there so we can have more cases covered by tests
dansanduleac
approved these changes
Jul 18, 2018
carterkozak
pushed a commit
to carterkozak/conjure-java
that referenced
this pull request
Dec 24, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #22. Since it was originally just an experiment and it caused #44, I hope its ok. I am keen to open up the discussion on how implement unions, especially if we have some numbers around the performance of one approach vs. another