Implement 'range' property for hover response #485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for your interest in palantir/python-language-server, @vhakulinen! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
gatesn
suggested changes
Feb 15, 2019
Contributor
gatesn
left a comment
gatesn
left a comment
There was a problem hiding this comment.
Thank you for this contribution, really nice. Couple of small comments then should be good to go
|
|
||
| return { | ||
| 'contents': _utils.format_docstring(definitions[0].docstring()) or "", | ||
| 'range': pos, |
| @@ -1,5 +1,6 @@ | |||
| # Copyright 2017 Palantir Technologies, Inc. | |||
| import logging | |||
| import json | |||
| if position['line'] >= len(self.lines): | ||
| return None | ||
|
|
||
| line = self.lines[position['line']] |
Contributor
There was a problem hiding this comment.
Can you add a test for this method explicitly?
Contributor
|
Copying over to a local branch so I can finish up the changes |
Author
|
Sorry, I completely forgot this while doing other stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
rangeproperty for thetextDocument/hoverresponse: https://microsoft.github.io/language-server-protocol/specification#textDocument_hover.