Explicitly define our TestDocumentSync capabilities#613
Merged
ccordoba12 merged 1 commit intopalantir:developfrom Jul 15, 2019
Merged
Explicitly define our TestDocumentSync capabilities#613ccordoba12 merged 1 commit intopalantir:developfrom
TestDocumentSync capabilities#613ccordoba12 merged 1 commit intopalantir:developfrom
Conversation
Member
|
Thanks for your interest in palantir/python-language-server, @mpanarin! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Contributor
|
@andfoy, please take a look at this one. |
gatesn
approved these changes
Jul 2, 2019
gatesn
suggested changes
Jul 2, 2019
mpanarin
force-pushed
the
define_capabilities
branch
from
9861806 to
a347596
Compare
Contributor
Author
|
@gatesn oops, updated. |
Contributor
Author
|
@ccordoba12 |
ccordoba12
changed the title
TestDocumentSync capabilitiesTestDocumentSync capabilities
Contributor
|
You're right, thanks for the reminder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to specification, passing a number in
TextDocumentSyncis for legacy support. I think we should move to an explicit declaration of capabilites, as modern clients require that (ex. Emacs lsp-mode will not send notifications that are not defined in capabilities, which is correct, imo).