Language server line numbers are zero-indexed

[dimbleby]

But flake8 gives one-indexed line numbers.

So all the diagnostics from the new flake8 linter were on the wrong line.

Unexpectedly (to me at least) the columns seem to be correct. Apparently flake8 returns 1-indexed line numbers and 0-indexed column numbers. Yay consistency.

[palantirtech]

Thanks for your interest in palantir/python-language-server, @dimbleby! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

[dimbleby]

Oh, a CLA. I don't expect to sign this, it's more trouble than it's worth to me, sorry.

Hopefully you can find some way of making this fix anyway, else this will be broken forever...

[ccordoba12]

Oh, a CLA. I don't expect to sign this, it's more trouble than it's worth to me, sorry.

Closing then, unfortunately.

Hopefully you can find some way of making this fix anyway, else this will be broken forever...

@youben11, please open a PR with this fix so we can include it in our next release.

[youben11]

Sure

[dimbleby]

Is it really your position that:

• it is not OK to accept a third-party contribution without a signed CLA ...
• ... unless you make a nominal effort to present those contributions as original
  ?

If so, well, I am surprised. I'd have guessed that whatever protection the CLA was supposed to be giving you cannot be obtained this way. Indeed, common sense would suggest that you're just making things worse.

But, whatever! It's all good by me.

[ccordoba12]

Sorry but signing the CLA is mandatory to merge PRs here. That's the decision of the creators of this project.

I'm just helping to maintain it on behalf of Spyder because it's a critical piece of infrastructure for us.