Skip to content

Fix flake8 line indexing #674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2019
Merged

Fix flake8 line indexing #674

merged 1 commit into from
Oct 14, 2019

Conversation

@youben11
Copy link
Contributor

@youben11 youben11 commented Oct 14, 2019

fix #672

@ccordoba12 ccordoba12 added this to the 0.29.1 milestone Oct 14, 2019
@ccordoba12 ccordoba12 changed the title fix flake8 line indexing Fix flake8 line indexing Oct 14, 2019
ccordoba12
ccordoba12 approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @youben11!

@ccordoba12 ccordoba12 merged commit 8db7654 into palantir:develop Oct 14, 2019
@ccordoba12
Copy link
Contributor

ccordoba12 commented Oct 14, 2019

I just released 0.29.1 with this fix because it was critical for the new flake8 plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.29.1

Development

Successfully merging this pull request may close these issues.

2 participants

@youben11 @ccordoba12