Add missing test for rope_rename.py#780
Merged
ccordoba12 merged 4 commits intopalantir:developfrom May 9, 2020
benmezger:tests/add-missing-plugins-tests
Merged
Add missing test for rope_rename.py#780ccordoba12 merged 4 commits intopalantir:developfrom benmezger:tests/add-missing-plugins-tests
ccordoba12 merged 4 commits intopalantir:developfrom
benmezger:tests/add-missing-plugins-tests
Conversation
ccordoba12
changed the title
ccordoba12
reviewed
Apr 21, 2020
| @pytest.fixture | ||
| def tmp_workspace(workspace): | ||
| def create_file(name, content): | ||
| fn = os.path.join(workspace.root_path, name) |
Contributor
There was a problem hiding this comment.
Where is the root_path of this workspace?
Contributor
Author
There was a problem hiding this comment.
Hey @ccordoba12 sorry for the late reply, I didn't get notified about this comment.
root_path is currently set to /private/var/folders/25/cy4pgsqn2393lvfmh420gf7h0000gn/T/pytest-of-benmezger/pytest-0/test_rope_rename0 on my machine.
Contributor
Author
There was a problem hiding this comment.
This is actually copied from:
Contributor
There was a problem hiding this comment.
Ok, thanks for the clarification 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a missing test to
plugins/rope_rename.pyimproving coverage.