Allow passing explicit environment variables to Jedi environment#822
Allow passing explicit environment variables to Jedi environment#822ccordoba12 merged 4 commits intopalantir:developfrom
Conversation
|
Thanks for your interest in palantir/python-language-server, @mrclary! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
50f77bc to
7c2559d
Compare
7c2559d to
07641b6
Compare
|
@palantirtech Can you take a look at this PR? |
|
Closing and reopening to re-trigger our CIs |
|
Ok, that didn't work. @mrclary, could you do a |
|
@ccordoba12, Done. I had to make a correction anyway. |
921f44d to
7c686e2
Compare
7c686e2 to
fd1508c
Compare
|
@ccordoba12, It looks like I missed the 0.35.0 and 0.35.1 releases. |
fd1508c to
62177b0
Compare
That avoids an error in Jedi
…create_environment
|
I'm testing this as part of spyder-ide/spyder#13839. Once tests pass there, I'll merge this one. |
There was a problem hiding this comment.
Thanks @mrclary! I added two commits to finish this one:
- One to remove PYTHONPATH from env_vars before creating the Jedi environment because it makes Jedi throw an error.
- Another to Increase our requirement on Jedi to
0.17.2in order to use your improvements in a cleaner way.
This permits passing explicit environment variables to the jedi environment, which is just passed to
subprocess.Popen'senvkeyword argument. See davidhalter/jedi#1617 and davidhalter/jedi#1619.