Skip to content

Allow passing explicit environment variables to Jedi environment#822

Merged
ccordoba12 merged 4 commits intopalantir:developfrom
mrclary:jedi-environment-variables
Sep 26, 2020
Merged

Allow passing explicit environment variables to Jedi environment#822
ccordoba12 merged 4 commits intopalantir:developfrom
mrclary:jedi-environment-variables

Conversation

@mrclary
Copy link
Copy Markdown
Contributor

@mrclary mrclary commented Jun 21, 2020

This permits passing explicit environment variables to the jedi environment, which is just passed to subprocess.Popen's env keyword argument. See davidhalter/jedi#1617 and davidhalter/jedi#1619.

@palantirtech
Copy link
Copy Markdown
Member

Thanks for your interest in palantir/python-language-server, @mrclary! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@mrclary mrclary force-pushed the jedi-environment-variables branch 4 times, most recently from 50f77bc to 7c2559d Compare June 25, 2020 17:01
@mrclary mrclary force-pushed the jedi-environment-variables branch from 7c2559d to 07641b6 Compare July 19, 2020 03:13
@mrclary
Copy link
Copy Markdown
Contributor Author

mrclary commented Jul 19, 2020

@palantirtech Can you take a look at this PR?
The only failure is test_exit_with_parent_process_died, which had a TimeoutError, but it seems to pass for me locally.

@ccordoba12
Copy link
Copy Markdown
Contributor

Closing and reopening to re-trigger our CIs

@ccordoba12 ccordoba12 closed this Jul 22, 2020
@ccordoba12 ccordoba12 reopened this Jul 22, 2020
@ccordoba12
Copy link
Copy Markdown
Contributor

Ok, that didn't work. @mrclary, could you do a git commit --amend and push again to trigger our CIs from your side?

@mrclary
Copy link
Copy Markdown
Contributor Author

mrclary commented Jul 22, 2020

@ccordoba12, Done. I had to make a correction anyway.

@mrclary
Copy link
Copy Markdown
Contributor Author

mrclary commented Sep 17, 2020

@ccordoba12, It looks like I missed the 0.35.0 and 0.35.1 releases.
Is it possible to get this into the next release?

@mrclary mrclary force-pushed the jedi-environment-variables branch from fd1508c to 62177b0 Compare September 23, 2020 06:57
@ccordoba12 ccordoba12 added this to the 0.36.0 milestone Sep 26, 2020
@ccordoba12
Copy link
Copy Markdown
Contributor

I'm testing this as part of spyder-ide/spyder#13839. Once tests pass there, I'll merge this one.

Copy link
Copy Markdown
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary! I added two commits to finish this one:

  • One to remove PYTHONPATH from env_vars before creating the Jedi environment because it makes Jedi throw an error.
  • Another to Increase our requirement on Jedi to 0.17.2 in order to use your improvements in a cleaner way.

@ccordoba12 ccordoba12 changed the title Allow passing explicit environment variables to jedi environment Allow passing explicit environment variables to Jedi environment Sep 26, 2020
@ccordoba12 ccordoba12 merged commit 3af83fe into palantir:develop Sep 26, 2020
@mrclary mrclary deleted the jedi-environment-variables branch September 27, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants