Skip to content

Resolve flake8_executable allowing ~/${HOME} paths#869

Merged
ccordoba12 merged 2 commits intopalantir:developfrom
kenodegard:patch-1
Oct 3, 2020
Merged

Resolve flake8_executable allowing ~/${HOME} paths#869
ccordoba12 merged 2 commits intopalantir:developfrom
kenodegard:patch-1

Conversation

@kenodegard
Copy link
Copy Markdown
Contributor

Instead of requiring an absolute and fully resolved flake8_executable allow ~/path/to/flake8, ${HOME}/path/to/flake8, etc.

@palantirtech
Copy link
Copy Markdown
Member

Thanks for your interest in palantir/python-language-server, @njalerikson! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@ccordoba12 ccordoba12 added this to the 0.36.0 milestone Oct 3, 2020
Comment thread pyls/plugins/flake8_lint.py Outdated
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Copy link
Copy Markdown
Contributor

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @njalerikson!

@ccordoba12 ccordoba12 merged commit 91a1368 into palantir:develop Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants