Create Team page with modular card layout (#60)#98
Create Team page with modular card layout (#60)#98q404365631 wants to merge 1 commit intopalladius:mainfrom
Conversation
✅ Deploy Preview for rubycon canceled.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new team page (team.html) that dynamically displays member information using Jekyll's site.team collection. Feedback highlights that the necessary team data is missing from the configuration, and the required updates to site_version and CHANGELOG.md were omitted in violation of the style guide. Additionally, the custom CSS should be refactored to use existing project variables or Tailwind CSS for better consistency and to avoid layout conflicts.
| --- | ||
|
|
||
| <div class="team-grid"> | ||
| {% for member in site.team %} |
There was a problem hiding this comment.
The template iterates over site.team, but this data is not defined in the provided _config.yml. To ensure the page displays content, the team members' data should be added to the configuration file as mentioned in the PR description.
| --- | ||
| layout: page | ||
| title: Team | ||
| permalink: /team/ | ||
| --- |
There was a problem hiding this comment.
According to the repository style guide (lines 50 and 78), every change must be accompanied by an update to the site_version in _config.yml and a new entry in CHANGELOG.md. These updates are missing from this pull request.
References
- Whenever you do a change to the file, please update the version: field in rubycon.it/_config.yml (with semantic versioning) and CHANGELOG.md. (link)
| .team-grid { display: grid; grid-template-columns: repeat(auto-fill, minmax(280px, 1fr)); gap: 2rem; padding: 2rem; } | ||
| .team-card { background: var(--card-bg); border-radius: 12px; padding: 1.5rem; text-align: center; box-shadow: 0 2px 8px rgba(0,0,0,0.1); transition: transform 0.2s; } | ||
| .team-card:hover { transform: translateY(-4px); } | ||
| .team-avatar { width: 100px; height: 100px; border-radius: 50%; object-fit: cover; margin-bottom: 1rem; } | ||
| .team-card h3 { margin: 0.5rem 0; color: var(--heading-color); } | ||
| .role { color: var(--accent-color); font-weight: 600; font-size: 0.9rem; margin: 0.5rem 0; } | ||
| .bio { color: var(--text-muted); font-size: 0.85rem; line-height: 1.5; } | ||
| .links a { margin: 0 0.5rem; color: var(--link-color); text-decoration: none; } |
There was a problem hiding this comment.
The CSS uses several variables (e.g., var(--card-bg), var(--accent-color)) that are not defined in the project's _variables.scss. Additionally, the .team-grid padding might conflict with the existing padding in the page layout (px-6 md:px-8). Given the project's recent move to a 'Roman' theme (Wine Red #802126 and Cream #fcf7e8) and the use of Tailwind CSS in other layouts (as seen in _layouts/page.html), consider using Tailwind classes or the established color palette for better consistency.
1 participant
New
/team/page featuring:_config.ymlteam arrayCloses #60